Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collect metrics for when t2viz triggered #510

Merged
merged 3 commits into from
Mar 17, 2025
Merged

feat: collect metrics for when t2viz triggered #510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59b8be9
feat: collect metrics for when t2viz triggered
ruanyl Mar 17, 2025
545d8b1
update CHANGELOG
ruanyl Mar 17, 2025
625f0e5
update release-notes
ruanyl Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

### Bug Fixes

- Remove text in badge to make it compatible with small screen ([#509](https://github.com/opensearch-project/dashboards-assistant/pull/509))

### Infrastructure

### Documentation
Expand Down
10 changes: 9 additions & 1 deletion public/components/visualization/text2viz.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,17 @@ export const Text2Viz = () => {
dataSourceId: indexPattern.dataSourceRef?.id,
});

if (usageCollection) {
usageCollection.reportUiStats(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to have a UT for this I think, easily missing for metrics.

VIS_NLQ_APP_ID,
usageCollection.METRIC_TYPE.CLICK,
`triggered-${uuidv4()}`
);
}

setSubmitting(false);
},
[selectedSource, inputQuestion, status, notifications.toasts]
[selectedSource, inputQuestion, status, notifications.toasts, usageCollection]
);

/**
Expand Down
4 changes: 2 additions & 2 deletions release-notes/dashboards-assistant.release-notes-3.0.0.0-alpha1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ Compatible with OpenSearch and OpenSearch Dashboards version 3.0.0-alpha1
- Generate visualization on t2v page mount ([#505](https://github.com/opensearch-project/dashboards-assistant/pull/505))
- Update insight badge ([#507](https://github.com/opensearch-project/dashboards-assistant/pull/507))


### Enhancements

- remove os_insight agent ([#452](https://github.com/opensearch-project/dashboards-assistant/pull/452))
Expand All @@ -27,7 +26,7 @@ Compatible with OpenSearch and OpenSearch Dashboards version 3.0.0-alpha1
- Show error message if PPL query does not contain aggregation ([#499](https://github.com/opensearch-project/dashboards-assistant/pull/499))
- Adjust the overall style of alert summary popover ([#501](https://github.com/opensearch-project/dashboards-assistant/pull/501))
- Add http error instruction for t2ppl task ([#502](https://github.com/opensearch-project/dashboards-assistant/pull/502))

- collect metrics for when t2viz triggered([#510](https://github.com/opensearch-project/dashboards-assistant/pull/510))

### Bug Fixes

Expand All @@ -44,6 +43,7 @@ Compatible with OpenSearch and OpenSearch Dashboards version 3.0.0-alpha1
- Fix error handling for data source connection errors ([#500](https://github.com/opensearch-project/dashboards-assistant/pull/500))
- Fix bug by hiding alert summary when clicking alert name ([#482](https://github.com/opensearch-project/dashboards-assistant/pull/482))
- Fix alert summary message action position when no discover button ([#504](https://github.com/opensearch-project/dashboards-assistant/pull/504))
- Remove text in badge to make it compatible with small screen ([#509](https://github.com/opensearch-project/dashboards-assistant/pull/509))

### Maintenance

Expand Down
Loading