Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chatbot dock bottom border top #511

Merged
merged 3 commits into from
Mar 17, 2025
Merged

chatbot dock bottom border top #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edebded
chatbot dock bottom border top
yyfamazon Mar 17, 2025
c722883
Merge branch 'main' into boarderTop
yyfamazon Mar 17, 2025
90fa332
Merge branch 'opensearch-project:main' into boarderTop
yyfamazon Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions public/chat_flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { ChatWindowHeader } from './tabs/chat_window_header';
import { ChatHistoryPage } from './tabs/history/chat_history_page';
import { AgentFrameworkTracesFlyoutBody } from './components/agent_framework_traces_flyout_body';
import { TAB_ID } from './utils/constants';
import { SIDECAR_DOCKED_MODE } from '../../../src/core/public';

interface ChatFlyoutProps {
flyoutVisible: boolean;
Expand Down Expand Up @@ -77,12 +78,17 @@ export const ChatFlyout = (props: ChatFlyoutProps) => {

const leftPanelSize = getLeftPanelSize();
const rightPanelSize = getRightPanelSize();
const { sidecarDockedMode } = useChatContext();

return (
<div
className={cs('llm-chat-flyout', {
'llm-chat-fullscreen': props.flyoutFullScreen,
})}
className={cs(
'llm-chat-flyout',
{
'llm-chat-fullscreen': props.flyoutFullScreen,
},
{ 'llm-chatbot-border-top': sidecarDockedMode === SIDECAR_DOCKED_MODE.TAKEOVER }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A UT would be nice to cover this case.

)}
>
<>
<div className={cs('llm-chat-flyout-header')}>
Expand Down
4 changes: 4 additions & 0 deletions public/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@
}
}

.llm-chatbot-border-top {
border-top: 1px solid $ouiBorderColor;
}

.llm-chat-flyout-header {
padding-top: 4px;
}
Expand Down
Loading