Database selector in "Set Up Integration" page #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiddis
requested changes
Mar 7, 2025
public/components/integrations/components/setup_integration.tsx
Outdated
Show resolved
Hide resolved
public/components/integrations/components/setup_integration.tsx
Outdated
Show resolved
Hide resolved
Swiddis
reviewed
Mar 7, 2025
public/components/integrations/components/setup_integration.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
* support custom logs correlation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add support for custom field mappings in logs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update explorer fields Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add support for custom timestamp field Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
Swiddis
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Looks good! Just leaving some additional thoughts. @sumukhswamy can you give a second review?
public/components/integrations/components/setup_integration.tsx
Outdated
Show resolved
Hide resolved
| setLoading(false); | ||
| setCalloutLikeToast('Failed to add integration', 'danger', result.error.message); |
There was a problem hiding this comment.
Not blocking, is good to have but repo needs a pass to be uniform in its implementation.
public/components/integrations/components/setup_integration.tsx
Outdated
Show resolved
Hide resolved
|
chore: Test snapshots need updates |
…ade by Simeon Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
TackAdam
approved these changes
Mar 11, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
* Database selector in Integration install Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * Database selector in Integration install Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * Database selector in Integration install Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * These changes are in response to PR comments Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * Support custom logs correlation (#2375) * support custom logs correlation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add support for custom field mappings in logs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update explorer fields Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add support for custom timestamp field Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * These changes are in response to latest PR comments and suggestions made by Simeon Signed-off-by: Aaron Alvarez <aaarone@amazon.com> --------- Signed-off-by: Aaron Alvarez <aaarone@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Aaron Alvarez <aaarone@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 588c8d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Swiddis
added
the
integrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when an Integration is created through the "Set Up Integration" page, the default database is hardcoded, as the table template is created as
${dataSource}.default.${tableName}. In order to avoid hard coding the database name, this feature allows the user to specify the database, and add their value in the template.Issues Resolved
This feature will allow the user to specify the database name, and add their value in the template.
Video Walkthrough
Here's a walkthrough of the feature:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.