Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling when setting up and reading a new integration #2387

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

aalva500-prog
Copy link
Contributor

@aalva500-prog aalva500-prog commented Mar 12, 2025

Description

When setting up a new integration and creating the configuration file with the assets and components, I received error messages when running the "yarn test repository.test.ts" command to verify that the integration I was configuring was correct. These messages weren't helpful in troubleshooting the issue; therefore, I made some changes that allowed me to better manage the problem and eventually resolve it.

Issues Resolved

Better error handling when reading a configuration json file of an integration.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • [] New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

aaarone90 and others added 11 commits March 7, 2025 16:40
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
* support custom logs correlation

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* add support for custom field mappings in logs

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update explorer fields

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* add support for custom timestamp field

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
…ade by Simeon

Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aalva500-prog aalva500-prog marked this pull request as ready for review March 13, 2025 17:52
@aalva500-prog aalva500-prog changed the title Improved error handling when setting up and reading a new integration Improve error handling when setting up and reading a new integration Mar 13, 2025
@Swiddis Swiddis self-requested a review March 13, 2025 17:52
@Swiddis Swiddis added enhancement New feature or request integrations Used to denote items related to the Integrations project infrastructure and removed enhancement New feature or request labels Mar 13, 2025
Copy link
Collaborator

@Swiddis Swiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Approving with one non-blocking enhancement.

Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure integrations Used to denote items related to the Integrations project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants