Add release note for 2.5.0 #135

mingshl · 2023-01-11T00:40:17Z

Description

Add release notes for 2.5.0

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

…search-relevance-2.5release

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

codecov-commenter · 2023-01-11T00:49:40Z

Codecov Report

Merging #135 (6778c48) into main (a866df1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files          13       13           
  Lines         140      140           
  Branches       27       27           
=======================================
  Hits          114      114           
  Misses         24       24           
  Partials        2        2

Flag	Coverage Δ
dashboards-search-relevance	`81.42% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

…search-relevance-2.5release

noCharger · 2023-01-11T02:12:10Z

release-notes/opensearch-dashboards-search-relevance.release-notes-2.5.0.0.md

@@ -0,0 +1,13 @@
+Compatible with OpenSearch and OpenSearch Dashboards Version 2.5.0
+### 🛡 Security
+* Update yarn.lock ([#107](https://github.com/opensearch-project/dashboards-search-relevance/pull/107))([#113](https://github.com/opensearch-project/dashboards-search-relevance/pull/113))


107 and 113 are for the 3 cve security fix.

Can we not combine them?

notified in other repo, if multiple PR for the same issues, they are likely notified in the same bullet point, sample here

If you really want to do that, then please also refine the content to be more meaningful

I like keeping them on the same line. I also agree with making the descriptions more meaningful by saying why the pull request exists in the title. Moving forward, let's make PR titles part of the review process so this doesn't HAVE to be handled in the release notes.

@noCharger @macohen rename the pr title #113 with Bump version for ansi-regex, gs, glob-parent and update yarn.lock. I hope this title make more sense for the 3 packages version update and yarn lock update all together.

We don't need commit subject lines to explain why a commit is made. See https://cbea.ms/git-commit/ for guidance.

However, we do need the release notes to summarize things in a way that's relevant to readers.

Edit: If we're talking about PR subject lines, I guess that's fine. By default, that's the commit subject, but yeah, we can always fix them up at PR time.

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

noCharger

The new message is a good summary of both PRs. Approved

* Add config rule in release note for security category Signed-off-by: Mingshi Liu <mingshl@amazon.com> * Add Release Notes for 2.4.1 Signed-off-by: Mingshi Liu <mingshl@amazon.com> * 2.4 changing to 2.4.0 Signed-off-by: Mingshi Liu <mingshl@amazon.com> * Add Release Notes for 2.5.0 Signed-off-by: Mingshi Liu <mingshl@amazon.com> * Add related ticket 107 Signed-off-by: Mingshi Liu <mingshl@amazon.com> * rename pr 113 Signed-off-by: Mingshi Liu <mingshl@amazon.com> * remove extra space Signed-off-by: Mingshi Liu <mingshl@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com> (cherry picked from commit c9ebb2e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Add config rule in release note for security category Signed-off-by: Mingshi Liu <mingshl@amazon.com> * Add Release Notes for 2.4.1 Signed-off-by: Mingshi Liu <mingshl@amazon.com> * 2.4 changing to 2.4.0 Signed-off-by: Mingshi Liu <mingshl@amazon.com> * Add Release Notes for 2.5.0 Signed-off-by: Mingshi Liu <mingshl@amazon.com> * Add related ticket 107 Signed-off-by: Mingshi Liu <mingshl@amazon.com> * rename pr 113 Signed-off-by: Mingshi Liu <mingshl@amazon.com> * remove extra space Signed-off-by: Mingshi Liu <mingshl@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com> (cherry picked from commit c9ebb2e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

mingshl and others added 7 commits January 10, 2023 14:29

Add config rule in release note for security category

266d114

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

Add Release Notes for 2.4.1

0bf81e5

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

Merge branch 'opensearch-project:main' into main

35014db

2.4 changing to 2.4.0

52f3814

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

Merge branch 'main' of https://github.com/mingshl/mingshl-dashboards-…

ea34188

…search-relevance-2.5release

Add Release Notes for 2.5.0

4db45e2

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

Merge branch 'opensearch-project:main' into main

967a6cd

mingshl added 2.x 2.x branch backport 2.x v2.5.0 maintenance A change to add support for new versions of OpenSearch or OpenSearch Dashboards from upstream. backport 2.5 labels Jan 11, 2023

mingshl requested a review from a team January 11, 2023 00:40

mingshl self-assigned this Jan 11, 2023

mingshl added 2 commits January 10, 2023 16:51

Add related ticket 107

7f7b979

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

Merge branch 'main' of https://github.com/mingshl/mingshl-dashboards-…

6778c48

…search-relevance-2.5release

mingshl changed the title ~~Add release notes for 2.5.0~~ Add release note for 2.5.0 Jan 11, 2023

noCharger reviewed Jan 11, 2023

View reviewed changes

mingshl added 2 commits January 11, 2023 09:22

rename pr 113

9f3dd47

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

remove extra space

84baf3b

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

noCharger approved these changes Jan 11, 2023

View reviewed changes

mingshl merged commit c9ebb2e into opensearch-project:main Jan 11, 2023

github-actions bot mentioned this pull request Jan 11, 2023

[Backport 2.x] Add release note for 2.5.0 #137

Merged

github-actions bot mentioned this pull request Jan 11, 2023

[Backport 2.5] Add release note for 2.5.0 #138

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add release note for 2.5.0 #135

Add release note for 2.5.0 #135

mingshl commented Jan 11, 2023

codecov-commenter commented Jan 11, 2023 •

edited

Loading

noCharger Jan 11, 2023

mingshl Jan 11, 2023

noCharger Jan 11, 2023

mingshl Jan 11, 2023

noCharger Jan 11, 2023

macohen Jan 11, 2023

mingshl Jan 11, 2023

msfroh Jan 11, 2023 •

edited

Loading

noCharger left a comment

Add release note for 2.5.0 #135

Add release note for 2.5.0 #135

Conversation

mingshl commented Jan 11, 2023

Description

codecov-commenter commented Jan 11, 2023 • edited Loading

Codecov Report

noCharger Jan 11, 2023

Choose a reason for hiding this comment

mingshl Jan 11, 2023

Choose a reason for hiding this comment

noCharger Jan 11, 2023

Choose a reason for hiding this comment

mingshl Jan 11, 2023

Choose a reason for hiding this comment

noCharger Jan 11, 2023

Choose a reason for hiding this comment

macohen Jan 11, 2023

Choose a reason for hiding this comment

mingshl Jan 11, 2023

Choose a reason for hiding this comment

msfroh Jan 11, 2023 • edited Loading

Choose a reason for hiding this comment

noCharger left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jan 11, 2023 •

edited

Loading

msfroh Jan 11, 2023 •

edited

Loading