added necessary files for building opensearch-2.x docker image #1
Conversation
README.md
Outdated
|
|
||
| * Change the title in this README | ||
| * Edit your repository description on GitHub | ||
| Master repository where Dockerfiles for Opensearch are hosted. These docker files are used to build images for Opensearch Offical Images |
There was a problem hiding this comment.
Maybe say
This repository hosts DockerFiles for OpenSearch and OpenSearch Dashboards. These docker files are used to build Offical docker Images for both the products.
There was a problem hiding this comment.
Since we decided on creating a separate repo for dashboards docker files don't think we should include dashboards here.
There was a problem hiding this comment.
My bad. Forgot about that but needs a little rewording to avoid terms like master.
There was a problem hiding this comment.
Updated to use Main.
| # This script should exit with the same code as the opensearch command, but | ||
| # it would be a breaking change. Next line should be uncommented for the | ||
| # next major release. | ||
| # exit ${opensearch_exit_code} |
There was a problem hiding this comment.
Maybe create an issue for this? @peterzhuamazon ?
There was a problem hiding this comment.
I have little memory of this where is this coming from @rishabh6788 ?
There was a problem hiding this comment.
Even I do not have any context about this. @gaiksaya can you provide some background about this issue?
There was a problem hiding this comment.
No idea hence asked @peterzhuamazon . Create an issue in this repo and keep. It can come as an enhancement
| function terminateProcesses { | ||
| if kill -0 $OPENSEARCH_PID >& /dev/null; then | ||
| echo "Killing opensearch process $OPENSEARCH_PID" | ||
| kill -TERM $OPENSEARCH_PID | ||
| wait $OPENSEARCH_PID | ||
| fi | ||
| if kill -0 $PA_PID >& /dev/null; then | ||
| echo "Killing performance analyzer process $PA_PID" | ||
| kill -TERM $PA_PID | ||
| wait $PA_PID | ||
| fi | ||
| } |
There was a problem hiding this comment.
We will need to de-couple these two tho.
Do you want to fix this now or in a follow-up PR?
There was a problem hiding this comment.
Will take it up in the follow up PR.
Need some more information around this.
Signed-off-by: Rishabh Singh <sngri@amazon.com>
|
Adding @dblock for visibility. In a nutshell the docker expects us to raise a PR against their repo https://github.com/docker-library/official-images which will contain a spec file in a certain format. That spec file contains information regarding the public git repository that contains the This PR is to add the Dockerfile that will be built by bashbrew tool. The Dockerfile needs to be built for the latest version of the software. All the older versions that were built before is preserved by docker and listed under official repositories tag. Please review the Dockerfile and all the supporting files and provide your comments. |
Description
This PR adds necessary files for building Opensearch docker images.
Issues Resolved
opensearch-project/opensearch-build#780
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.