Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to support SigV4 serverless service as a data source connection for Dashboards #4147

Merged
merged 13 commits into from
Jun 2, 2023

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented May 22, 2023

Description

A recent update includes support for the Amazon OpenSearch Serverless service for the SigV4 auth type. This supports the legacy js client.

Issues Resolved

Updates documentation to cover this service as an option when users select SigV4 for auth type.

Fixes #3983

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum cwillum added dashboards 2 - In progress Issue/PR: The issue or PR is in progress. release-notes PR: Include this PR in the automated release notes v2.8.0 labels May 22, 2023
@cwillum cwillum self-assigned this May 22, 2023
cwillum added 10 commits May 22, 2023 16:22
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
@hdhalter hdhalter added 3 - Tech review PR: Tech review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels May 24, 2023
@zhongnansu zhongnansu self-requested a review May 24, 2023 22:24
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cwillum cwillum added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels May 26, 2023
@cwillum
Copy link
Contributor Author

cwillum commented May 26, 2023

Will replace image once UI text is fixed.

@vagimeli
Copy link
Contributor

vagimeli commented May 30, 2023

Will replace image once UI text is fixed.

Here's suggested UI text if needed.

Enter the authentication details to access the endpoint. If no authentication is required, select No authentication.

Will replace image once UI text is fixed.

Copy link
Contributor

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwillum Minimal copy edits and a comment re: UI text

@hdhalter hdhalter added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels May 31, 2023
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum
Copy link
Contributor Author

cwillum commented Jun 1, 2023

We are aware that the text in the screen shot is missing a period at the end of the second sentence. This will be fixed in the future, and I'll swap out the image then.

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwillum Please see my comments and changes and let me know if you have any questions. Thanks!

@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label Jun 2, 2023
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum cwillum merged commit 58929ff into main Jun 2, 2023
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
…e connection for Dashboards (opensearch-project#4147)

* fix#3983 sigV4 serverless update

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#3983 sigV4 serverless update

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#3983 sigV4 serverless update

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#3983 sigV4 serverless update

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#3983 sigV4 serverless update

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#3983 sigV4 serverless update

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#3983 sigV4 serverless update

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#3983 sigV4 serverless update

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#3983 sigV4 serverless update

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#3983 sigV4 serverless update

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#3983 sigV4 serverless update

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#3983 sigV4 serverless update

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#3983 sigV4 serverless update

Signed-off-by: cwillum <cwmmoore@amazon.com>

---------

Signed-off-by: cwillum <cwmmoore@amazon.com>
@hdhalter hdhalter deleted the fix#3983-sigV4-serverless branch March 28, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboards release-notes PR: Include this PR in the automated release notes v2.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] [Multiple Datasource] Update documentation for AWS OpenSearch Serverlesss support in 2.8
5 participants