Add metric and stat entity #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
============================================
- Coverage 88.82% 88.72% -0.10%
- Complexity 102 130 +28
============================================
Files 15 18 +3
Lines 331 470 +139
Branches 27 35 +8
============================================
+ Hits 294 417 +123
- Misses 33 48 +15
- Partials 4 5 +1
Continue to review full report at Codecov.
|
VijayanB
force-pushed
the
add-stats
branch
5 times, most recently
from
53be034 to
c173dae
Compare
VijayanB
force-pushed
the
add-stats
branch
5 times, most recently
from
73a5922 to
b476167
Compare
jmazanec15
reviewed
Apr 27, 2022
src/main/java/org/opensearch/geospatial/action/upload/geojson/Uploader.java
Show resolved
Hide resolved
VijayanB
force-pushed
the
add-stats
branch
2 times, most recently
from
4cadf39 to
22ac006
Compare
jmazanec15
reviewed
Apr 28, 2022
| * @return Metric's Identifier | ||
| */ | ||
| public String getMetricID() { | ||
| return metricID; |
There was a problem hiding this comment.
Unique identifier for every upload request
| private long failedCount; | ||
| private String metricID; | ||
| private long successCount; | ||
| private long uploadCount; |
There was a problem hiding this comment.
Do these need to be initialized? Seems like metricID at the least should be a required parameter. What happens if this isnt set?
There was a problem hiding this comment.
Now metric id is required now. Default for all others are 0
| */ | ||
| public void addMetric(UploadMetric newMetric) { | ||
| Objects.requireNonNull(newMetric, "metric cannot be null"); | ||
| metrics.add(newMetric); |
There was a problem hiding this comment.
Do we check for duplicate metrics anywhere?
There was a problem hiding this comment.
changed to HashSet and using metric ID to validate duplicate metrics
VijayanB
force-pushed
the
add-stats
branch
3 times, most recently
from
eecee09 to
9547c10
Compare
src/main/java/org/opensearch/geospatial/action/upload/geojson/Uploader.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/geospatial/action/upload/geojson/UploadGeoJSONTransportAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Override toString to return lowercase. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Since metrics are added to hashset, it doesn't guarante the order anymore. Hence, test metrics individually. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
This type represent the geospatial object it uploaded. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
martin-gaievski
approved these changes
May 2, 2022
jmazanec15
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com
Description
Following metrics are added for the Upload API
Issues Resolved
#53
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.