Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to edit/create notifications using channels in IM #181

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

thalurur
Copy link
Contributor

@thalurur thalurur commented Apr 20, 2022

Description

[Describe what this change achieves]
Support visual policy creation for new notification channels

Legacy notification - only edit is allowed
image

New notification - create/edit is allowed
image

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dbbaughe and others added 2 commits April 17, 2022 23:35
Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
@thalurur thalurur requested a review from a team April 20, 2022 00:12
Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
@thalurur thalurur changed the title Adding support to edit/create new notification action in IM Adding support to edit/create notifications using channels in IM Apr 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #181 (093fc02) into main (ff0d056) will decrease coverage by 1.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   63.32%   61.85%   -1.48%     
==========================================
  Files         155      158       +3     
  Lines        4447     4632     +185     
  Branches      696      732      +36     
==========================================
+ Hits         2816     2865      +49     
- Misses       1415     1546     +131     
- Partials      216      221       +5     
Impacted Files Coverage Δ
...containers/ErrorNotification/ErrorNotification.tsx 84.61% <0.00%> (-15.39%) ⬇️
...mponents/EuiFormCustomLabel/EuiFormCustomLabel.tsx 80.00% <0.00%> (-7.50%) ⬇️
...m/components/DefineTransforms/DefineTransforms.tsx 69.64% <0.00%> (-5.36%) ⬇️
...ntainers/VisualCreatePolicy/VisualCreatePolicy.tsx 11.66% <0.00%> (-0.84%) ⬇️
...n/public/pages/VisualCreatePolicy/utils/helpers.ts 68.36% <0.00%> (-0.71%) ⬇️
...-dashboards-plugin/public/index_management_app.tsx 7.14% <0.00%> (-0.55%) ⬇️
...ex-management-dashboards-plugin/utils/constants.ts 100.00% <0.00%> (ø)
...ement-dashboards-plugin/public/pages/Main/Main.tsx 10.00% <0.00%> (ø)
...public/pages/VisualCreatePolicy/utils/constants.ts 100.00% <0.00%> (ø)
...mponents/LegacyNotification/LegacyNotification.tsx 75.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0d056...093fc02. Read the comment docs.

dbbaughe
dbbaughe previously approved these changes Apr 20, 2022
Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants