Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap up node removal and bump as dependabot suggest #193

Merged
merged 2 commits into from
May 10, 2022

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented May 9, 2022

Signed-off-by: bowenlan-amzn bowenlan23@gmail.com

Description

Continue node removal from #140

Calming down the dependabot

Issues Resolved

#137

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
@bowenlan-amzn bowenlan-amzn added the dependencies Pull requests that update a dependency file label May 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #193 (ec44731) into main (cb8a61b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   61.85%   61.85%           
=======================================
  Files         158      158           
  Lines        4632     4632           
  Branches      732      732           
=======================================
  Hits         2865     2865           
  Misses       1546     1546           
  Partials      221      221           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb8a61b...ec44731. Read the comment docs.

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review May 10, 2022 01:42
@bowenlan-amzn bowenlan-amzn requested a review from a team May 10, 2022 01:42
@bowenlan-amzn bowenlan-amzn merged commit 3d92836 into opensearch-project:main May 10, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-193-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3d92836eb48aa4c8e4da8ac4ea339ba9f0bd7ee6
# Push it to GitHub
git push --set-upstream origin backport/backport-193-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-193-to-2.0.

downsrob pushed a commit to downsrob/index-management-dashboards-plugin that referenced this pull request May 19, 2022
…ct#193)

* Wrap up node removal and bump as dependabot suggest

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* Change dashboard dep to 2.0.0-rc1

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
downsrob pushed a commit to downsrob/index-management-dashboards-plugin that referenced this pull request May 19, 2022
…ct#193)

* Wrap up node removal and bump as dependabot suggest

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* Change dashboard dep to 2.0.0-rc1

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
downsrob added a commit that referenced this pull request May 19, 2022
* Wrap up node removal and bump as dependabot suggest

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* Change dashboard dep to 2.0.0-rc1

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>

Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.0 dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants