-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot management small fixes #208
Merged
bowenlan-amzn
merged 13 commits into
opensearch-project:main
from
bowenlan-amzn:sm-small-fix
Jun 28, 2022
Merged
Snapshot management small fixes #208
bowenlan-amzn
merged 13 commits into
opensearch-project:main
from
bowenlan-amzn:sm-small-fix
Jun 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 51.84% 51.59% -0.25%
==========================================
Files 182 183 +1
Lines 5750 5795 +45
Branches 924 933 +9
==========================================
+ Hits 2981 2990 +9
- Misses 2548 2584 +36
Partials 221 221
Continue to review full report at Codecov.
|
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
de433d2
to
fa8f94e
Compare
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
AWSHurneyt
reviewed
Jun 28, 2022
public/pages/CreateSnapshotPolicy/containers/CreateSnapshotPolicy/CreateSnapshotPolicy.tsx
Show resolved
Hide resolved
public/pages/CreateSnapshotPolicy/containers/CreateSnapshotPolicy/CreateSnapshotPolicy.tsx
Outdated
Show resolved
Hide resolved
public/pages/CreateSnapshotPolicy/containers/CreateSnapshotPolicy/CreateSnapshotPolicy.tsx
Show resolved
Hide resolved
public/pages/CreateSnapshotPolicy/containers/CreateSnapshotPolicy/CreateSnapshotPolicy.tsx
Outdated
Show resolved
Hide resolved
public/pages/SnapshotPolicyDetails/containers/SnapshotPolicyDetails/SnapshotPolicyDetails.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
AWSHurneyt
approved these changes
Jun 28, 2022
downsrob
approved these changes
Jun 28, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 28, 2022
* Add notification Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Default timestamp in snapshot name Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Make custom configuration in create repo more prominent Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Tune the snapshots table to have more space for showing snapshot name Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Show notification channel name on policy detail page Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Helptext word change Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Add snapshot management to left side bar Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * max age unit sync with snapshot frequency type hourly Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Notification link to detail in policy detail page Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit 2947db6)
bowenlan-amzn
added a commit
that referenced
this pull request
Jun 28, 2022
* Add notification Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Default timestamp in snapshot name Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Make custom configuration in create repo more prominent Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Tune the snapshots table to have more space for showing snapshot name Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Show notification channel name on policy detail page Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Helptext word change Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Add snapshot management to left side bar Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * max age unit sync with snapshot frequency type hourly Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Notification link to detail in policy detail page Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit 2947db6) Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bowenlan-amzn bowenlan23@gmail.com
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.