Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refractor: move api calls from components to containers #322

Conversation

SuZhou-Joe
Copy link
Member

Signed-off-by: suzhou suzhou@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SuZhou-Joe SuZhou-Joe requested review from xluo-aws, Hailong-am and a team October 28, 2022 04:01
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Merging #322 (dcd95b8) into index-operation (3e79127) will increase coverage by 0.52%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           index-operation     #322      +/-   ##
===================================================
+ Coverage            51.97%   52.49%   +0.52%     
===================================================
  Files                  200      200              
  Lines                 6386     6414      +28     
  Branches              1007     1013       +6     
===================================================
+ Hits                  3319     3367      +48     
+ Misses                2817     2795      -22     
- Partials               250      252       +2     
Impacted Files Coverage Δ
...CreateIndex/components/IndexDetail/IndexDetail.tsx 63.79% <0.00%> (-1.93%) ⬇️
...ds-plugin/public/pages/Indices/utils/constants.tsx 87.50% <0.00%> (ø)
.../pages/Indices/components/IndicesActions/index.tsx
...lic/pages/Indices/components/IndexDetail/index.tsx
.../pages/Indices/containers/IndicesActions/index.tsx 95.83% <0.00%> (ø)
...lic/pages/Indices/containers/IndexDetail/index.tsx 85.71% <0.00%> (ø)
...CreateIndex/containers/CreateIndex/CreateIndex.tsx 53.15% <0.00%> (+0.77%) ⬆️
...eateIndex/components/IndexMapping/IndexMapping.tsx 71.42% <0.00%> (+0.89%) ⬆️
...ublic/pages/Indices/containers/Indices/Indices.tsx 82.60% <0.00%> (+3.94%) ⬆️
...ashboards-plugin/public/components/Modal/Modal.tsx 64.28% <0.00%> (+21.42%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: suzhou <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe force-pushed the refractor/indices-actions branch from d3170b4 to 1f85e1c Compare October 28, 2022 11:48
… indices container

Signed-off-by: suzhou <suzhou@amazon.com>
@Hailong-am Hailong-am merged commit 48f5ecb into opensearch-project:index-operation Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants