Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add diff confirm modal in create wizard #323

Merged

Conversation

SuZhou-Joe
Copy link
Member

Signed-off-by: suzhou suzhou@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SuZhou-Joe SuZhou-Joe requested review from gaobinlong, xluo-aws, Hailong-am and a team October 31, 2022 04:52
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Merging #323 (ea2203a) into index-operation (c781432) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           index-operation     #323      +/-   ##
===================================================
- Coverage            51.73%   51.69%   -0.05%     
===================================================
  Files                  213      214       +1     
  Lines                 7367     7396      +29     
  Branches              1263     1271       +8     
===================================================
+ Hits                  3811     3823      +12     
- Misses                3302     3315      +13     
- Partials               254      258       +4     
Impacted Files Coverage Δ
...ashboards-plugin/public/components/Modal/Modal.tsx 53.48% <0.00%> (-10.80%) ⬇️
...CreateIndex/containers/CreateIndex/CreateIndex.tsx 50.78% <0.00%> (-2.38%) ⬇️
.../pages/Indices/containers/IndicesActions/index.tsx 95.83% <0.00%> (ø)
...onents/FormGenerator/built_in_components/index.tsx 100.00% <0.00%> (ø)
...in/public/components/MonacoEditor/MonacoEditor.tsx 75.00% <0.00%> (ø)
...lic/pages/Indices/containers/IndexDetail/index.tsx 86.04% <0.00%> (+0.33%) ⬆️
...CreateIndex/components/IndexDetail/IndexDetail.tsx 70.49% <0.00%> (+2.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe force-pushed the feature/create-wizard branch from 3237a6c to 6b8a432 Compare November 2, 2022 06:33
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
@Hailong-am Hailong-am merged commit 5ec13c7 into opensearch-project:index-operation Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants