Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add form generator & advanced settings to speed up development in common form case #329

Conversation

SuZhou-Joe
Copy link
Member

Description

  1. Add a FormGenerator component to quickly setup a form with validation in simple json.
  2. Add a AdvancedSettings component for other case to reuse.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe requested review from a team, Hailong-am and xluo-aws November 2, 2022 05:59
@SuZhou-Joe SuZhou-Joe changed the title feature: Add form generator to reuse in common form case feature: Add form generator to speed up development in common form case Nov 2, 2022
@SuZhou-Joe SuZhou-Joe changed the title feature: Add form generator to speed up development in common form case feature: Add form generator & advanced settings to speed up development in common form case Nov 2, 2022
xluo-aws
xluo-aws previously approved these changes Nov 2, 2022
Hailong-am
Hailong-am previously approved these changes Nov 2, 2022
Signed-off-by: suzhou <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe dismissed stale reviews from Hailong-am and xluo-aws via e301cad November 2, 2022 06:28
@SuZhou-Joe SuZhou-Joe merged commit c781432 into opensearch-project:index-operation Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants