Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds min primary shard size rollover condition to the ISM rollover ac… #220

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

dbbaughe
Copy link
Contributor

@dbbaughe dbbaughe commented Dec 9, 2021

…tion

Signed-off-by: Drew Baugher 46505179+dbbaughe@users.noreply.github.com

Issue #, if available:
#213

Description of changes:

  • Adds min_primary_shard_size as a rollover condition to ISM rollover action.
  • It will evaluate to true when there is a single primary shard in the index that has a greater size than the condition.
  • Kept the prefix as min instead of max to be aligned with the other conditions we have in rollover, although it is odd that our conditions are differently named than the native rollover API conditions.

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…tion

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
@dbbaughe dbbaughe requested a review from a team December 9, 2021 23:29
Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
@dbbaughe
Copy link
Contributor Author

TODO: Open a PR on dashboards plugin to add this new option to the UI
This isn't blocking to get this PR in though for now

qreshi
qreshi previously approved these changes Dec 10, 2021
Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
@dbbaughe dbbaughe merged commit 62eada9 into opensearch-project:main Dec 10, 2021
@dbbaughe dbbaughe deleted the minprimaryshard branch December 10, 2021 19:16
downsrob pushed a commit to downsrob/index-management that referenced this pull request Mar 9, 2022
opensearch-project#220)

* Adds min primary shard size rollover condition to the ISM rollover action

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes config schema version tests

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Reverts async request in tests

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
downsrob pushed a commit to downsrob/index-management that referenced this pull request Mar 9, 2022
opensearch-project#220)

* Adds min primary shard size rollover condition to the ISM rollover action

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes config schema version tests

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Reverts async request in tests

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob pushed a commit that referenced this pull request Mar 9, 2022
#220)

* Adds min primary shard size rollover condition to the ISM rollover action

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes config schema version tests

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Reverts async request in tests

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Signed-off-by: Robert Downs <downsrob@amazon.com>
@sastorsl
Copy link

sastorsl commented May 2, 2022

Should perhaps have updated the docs aswell: https://opensearch.org/docs/latest/im-plugin/ism/policies/#rollover

wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
opensearch-project#220)

* Adds min primary shard size rollover condition to the ISM rollover action

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes config schema version tests

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Reverts async request in tests

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants