Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISM Template Migration #237

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Conversation

thalurur
Copy link
Contributor

@thalurur thalurur commented Dec 27, 2021

Signed-off-by: Ravi Thaluru thalurur@users.noreply.github.com

Issue #, if available:
N/A

Description of changes:

  • Porting the template migration code
  • Using metadataservice status setting to determine if the metadata migration is enabled rather than enabled setting
  • Porting other minor missing bugfixes

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@thalurur thalurur requested a review from a team December 27, 2021 17:17
@thalurur thalurur force-pushed the migrationFix branch 3 times, most recently from 53e5bfe to 1b6b982 Compare December 27, 2021 19:12
Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2021

Codecov Report

Attention: Patch coverage is 77.00348% with 66 lines in your changes missing coverage. Please review.

Project coverage is 76.11%. Comparing base (4572f32) to head (93141af).
Report is 222 commits behind head on main.

Files with missing lines Patch % Lines
...ndexstatemanagement/migration/MigrationServices.kt 79.21% 19 Missing and 18 partials ⚠️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 51.21% 10 Missing and 10 partials ⚠️
...management/indexstatemanagement/MetadataService.kt 68.18% 5 Missing and 2 partials ⚠️
...sport/action/addpolicy/TransportAddPolicyAction.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #237      +/-   ##
============================================
- Coverage     76.18%   76.11%   -0.08%     
- Complexity     1960     1964       +4     
============================================
  Files           260      261       +1     
  Lines         11222    11497     +275     
  Branches       1764     1808      +44     
============================================
+ Hits           8550     8751     +201     
- Misses         1709     1755      +46     
- Partials        963      991      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
Copy link
Member

@bowenlan-amzn bowenlan-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@thalurur thalurur merged commit 2117f17 into opensearch-project:main Dec 29, 2021
downsrob pushed a commit to downsrob/index-management that referenced this pull request Mar 9, 2022
Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
downsrob pushed a commit to downsrob/index-management that referenced this pull request Mar 9, 2022
Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob pushed a commit that referenced this pull request Mar 9, 2022
Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
Signed-off-by: Robert Downs <downsrob@amazon.com>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
Signed-off-by: Ravi Thaluru <thalurur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants