Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes flaky continuous transforms test #276

Merged

Conversation

downsrob
Copy link
Contributor

@downsrob downsrob commented Feb 24, 2022

Signed-off-by: Robert Downs downsrob@amazon.com

Issue #, if available:
N/A
Description of changes:

./gradlew ':integTest' --tests "org.opensearch.indexmanagement.transform.TransformRunnerIT.test continuous transform with wildcard indices" -Dtests.seed=7456CA873D2951BB -Dtests.security.manager=false -Dtests.locale=es-US -Dtests.timezone=Etc/Greenwich -Druntime.java=14
org.opensearch.indexmanagement.transform.TransformRunnerIT > test continuous transform with wildcard indices FAILED
    java.lang.NullPointerException
        at __randomizedtesting.SeedInfo.seed([7456CA873D2951BB:9E30041088F9C85C]:0)
        at java.base/java.time.Instant.compareTo(Instant.java:1255)
        at java.base/java.time.Instant.isAfter(Instant.java:1272)
        at org.opensearch.indexmanagement.transform.TransformRunnerIT.test continuous transform with wildcard indices(TransformRunnerIT.kt:771)

Noticed this flaky failure for continuous transforms. Metadata with the transform afterkey set to null was updated before the final step where the ContinuousStats were updated, so a test scenario in which the continuous stats were missing was possible. This change makes the waitFor loop wait for the continuous stats to be present.
CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Robert Downs <downsrob@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #276 (8c0d7ca) into main (97a8405) will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #276      +/-   ##
============================================
- Coverage     76.48%   76.26%   -0.23%     
+ Complexity     2027     2021       -6     
============================================
  Files           262      262              
  Lines         11749    11749              
  Branches       1869     1869              
============================================
- Hits           8986     8960      -26     
- Misses         1741     1767      +26     
  Partials       1022     1022              
Impacted Files Coverage Δ
...statemanagement/model/destination/CustomWebhook.kt 65.21% <0.00%> (-27.54%) ⬇️
...arch/indexmanagement/rollup/RollupSearchService.kt 55.55% <0.00%> (-3.71%) ⬇️
...dexmanagement/transform/model/TransformMetadata.kt 88.11% <0.00%> (-2.98%) ⬇️
...ndexstatemanagement/IndexStateManagementHistory.kt 77.30% <0.00%> (-2.84%) ⬇️
...ent/indexstatemanagement/util/ManagedIndexUtils.kt 78.48% <0.00%> (-1.27%) ⬇️
.../rollup/action/start/TransportStartRollupAction.kt 69.76% <0.00%> (+2.32%) ⬆️
...nt/indexstatemanagement/model/destination/Slack.kt 54.54% <0.00%> (+13.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a8405...8c0d7ca. Read the comment docs.

@downsrob downsrob marked this pull request as ready for review February 25, 2022 00:47
@downsrob downsrob requested review from a team, bowenlan-amzn, dbbaughe and thalurur February 25, 2022 00:47
@downsrob downsrob merged commit cb2900b into opensearch-project:main Feb 25, 2022
@downsrob downsrob deleted the flakey-continuous-transforms branch February 25, 2022 16:41
@downsrob downsrob mentioned this pull request Feb 25, 2022
1 task
downsrob added a commit to downsrob/index-management that referenced this pull request Mar 9, 2022
Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob added a commit to downsrob/index-management that referenced this pull request Mar 9, 2022
Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob added a commit that referenced this pull request Mar 9, 2022
Signed-off-by: Robert Downs <downsrob@amazon.com>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
Signed-off-by: Robert Downs <downsrob@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants