-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes flaky continuous transforms test #276
Merged
downsrob
merged 1 commit into
opensearch-project:main
from
downsrob:flakey-continuous-transforms
Feb 25, 2022
Merged
Fixes flaky continuous transforms test #276
downsrob
merged 1 commit into
opensearch-project:main
from
downsrob:flakey-continuous-transforms
Feb 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Downs <downsrob@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
============================================
- Coverage 76.48% 76.26% -0.23%
+ Complexity 2027 2021 -6
============================================
Files 262 262
Lines 11749 11749
Branches 1869 1869
============================================
- Hits 8986 8960 -26
- Misses 1741 1767 +26
Partials 1022 1022
Continue to review full report at Codecov.
|
thalurur
approved these changes
Feb 25, 2022
bowenlan-amzn
approved these changes
Feb 25, 2022
1 task
downsrob
added a commit
to downsrob/index-management
that referenced
this pull request
Mar 9, 2022
Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob
added a commit
to downsrob/index-management
that referenced
this pull request
Mar 9, 2022
Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob
added a commit
that referenced
this pull request
Mar 9, 2022
Signed-off-by: Robert Downs <downsrob@amazon.com>
wuychn
pushed a commit
to ochprince/index-management
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Robert Downs <downsrob@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robert Downs downsrob@amazon.com
Issue #, if available:
N/A
Description of changes:
Noticed this flaky failure for continuous transforms. Metadata with the transform afterkey set to null was updated before the final step where the ContinuousStats were updated, so a test scenario in which the continuous stats were missing was possible. This change makes the waitFor loop wait for the continuous stats to be present.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.