Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes integ test java version from 14 to 11 #284

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

downsrob
Copy link
Contributor

@downsrob downsrob commented Mar 4, 2022

Signed-off-by: Robert Downs downsrob@amazon.com

Issue #, if available:
#200

Description of changes:
Changes the default Java version for CI in GitHub actions from 14 to 11.
CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

downsrob added 2 commits March 4, 2022 17:19
Signed-off-by: Robert Downs <downsrob@amazon.com>
Signed-off-by: Robert Downs <downsrob@amazon.com>
@downsrob downsrob requested a review from a team March 4, 2022 18:05
@codecov-commenter
Copy link

Codecov Report

Merging #284 (49ede6c) into main (ec01cdf) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #284      +/-   ##
============================================
- Coverage     76.43%   76.35%   -0.09%     
- Complexity     2030     2048      +18     
============================================
  Files           262      262              
  Lines         11780    11848      +68     
  Branches       1870     1887      +17     
============================================
+ Hits           9004     9046      +42     
- Misses         1760     1776      +16     
- Partials       1016     1026      +10     
Impacted Files Coverage Δ
...statemanagement/model/destination/CustomWebhook.kt 65.21% <0.00%> (-27.54%) ⬇️
...temanagement/opensearchapi/OpenSearchExtensions.kt 77.21% <0.00%> (-1.86%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 71.79% <0.00%> (-0.97%) ⬇️
...earch/indexmanagement/transform/TransformRunner.kt 86.42% <0.00%> (-0.72%) ⬇️
...transport/action/explain/TransportExplainAction.kt 66.49% <0.00%> (-0.70%) ⬇️
...agement/indexstatemanagement/ManagedIndexRunner.kt 55.38% <0.00%> (-0.32%) ⬇️
...earch/indexmanagement/transform/model/Transform.kt 85.21% <0.00%> (ø)
.../action/explain/TransportExplainTransformAction.kt 67.04% <0.00%> (ø)
.../indexmanagement/indexstatemanagement/step/Step.kt 95.23% <0.00%> (+0.23%) ⬆️
.../opensearch/indexmanagement/rollup/model/Rollup.kt 84.43% <0.00%> (+0.47%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec01cdf...49ede6c. Read the comment docs.

@dbbaughe
Copy link
Contributor

dbbaughe commented Mar 7, 2022

Is there a reason for going down? And any reason for not having both run in a matrix if both are supported?

@downsrob
Copy link
Contributor Author

downsrob commented Mar 7, 2022

Is there a reason for going down? And any reason for not having both run in a matrix if both are supported?

@dbbaughe core java version is going to 11 so we are being asked to change CI to the same version. Core is going down as 14 is not a long term support java version. We were asked to include java 8, 11, 14, and 17 in a matrix (ref: #200)
I didn't do that because we have flaky test failures again. Say we made the multinode test run a matrix of 8, 11, 14, and 17. If we have a 15% chance of having a flaky failure on any given run, then we are failing at least one of the runs nearly 50% of the time (1 - .85^4 = .48), and when you retry, you can't retry just one version, you need to retry the full matrix.

Let me know if you think we still should though, or if you think we should do a matrix of just two versions. Java 17 is what we will be moving to next.

@downsrob downsrob requested a review from dbbaughe March 9, 2022 01:15
@downsrob downsrob merged commit 20ff74e into opensearch-project:main Mar 9, 2022
@downsrob downsrob deleted the java-version branch March 9, 2022 17:35
downsrob added a commit to downsrob/index-management that referenced this pull request Mar 9, 2022
* Changes integ test java version from 14 to 11

Signed-off-by: Robert Downs <downsrob@amazon.com>

* Updated dev guide

Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob added a commit to downsrob/index-management that referenced this pull request Mar 9, 2022
* Changes integ test java version from 14 to 11

Signed-off-by: Robert Downs <downsrob@amazon.com>

* Updated dev guide

Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob added a commit that referenced this pull request Mar 9, 2022
* Changes integ test java version from 14 to 11

Signed-off-by: Robert Downs <downsrob@amazon.com>

* Updated dev guide

Signed-off-by: Robert Downs <downsrob@amazon.com>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
* Changes integ test java version from 14 to 11

Signed-off-by: Robert Downs <downsrob@amazon.com>

* Updated dev guide

Signed-off-by: Robert Downs <downsrob@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants