-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes integ test java version from 14 to 11 #284
Conversation
Signed-off-by: Robert Downs <downsrob@amazon.com>
Signed-off-by: Robert Downs <downsrob@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #284 +/- ##
============================================
- Coverage 76.43% 76.35% -0.09%
- Complexity 2030 2048 +18
============================================
Files 262 262
Lines 11780 11848 +68
Branches 1870 1887 +17
============================================
+ Hits 9004 9046 +42
- Misses 1760 1776 +16
- Partials 1016 1026 +10
Continue to review full report at Codecov.
|
Is there a reason for going down? And any reason for not having both run in a matrix if both are supported? |
@dbbaughe core java version is going to 11 so we are being asked to change CI to the same version. Core is going down as 14 is not a long term support java version. We were asked to include java 8, 11, 14, and 17 in a matrix (ref: #200) Let me know if you think we still should though, or if you think we should do a matrix of just two versions. Java 17 is what we will be moving to next. |
* Changes integ test java version from 14 to 11 Signed-off-by: Robert Downs <downsrob@amazon.com> * Updated dev guide Signed-off-by: Robert Downs <downsrob@amazon.com>
* Changes integ test java version from 14 to 11 Signed-off-by: Robert Downs <downsrob@amazon.com> * Updated dev guide Signed-off-by: Robert Downs <downsrob@amazon.com>
* Changes integ test java version from 14 to 11 Signed-off-by: Robert Downs <downsrob@amazon.com> * Updated dev guide Signed-off-by: Robert Downs <downsrob@amazon.com>
* Changes integ test java version from 14 to 11 Signed-off-by: Robert Downs <downsrob@amazon.com> * Updated dev guide Signed-off-by: Robert Downs <downsrob@amazon.com>
Signed-off-by: Robert Downs downsrob@amazon.com
Issue #, if available:
#200
Description of changes:
Changes the default Java version for CI in GitHub actions from 14 to 11.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.