-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors shrink action steps and adds unit tests #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
============================================
+ Coverage 75.09% 75.30% +0.20%
- Complexity 2135 2155 +20
============================================
Files 262 263 +1
Lines 12444 12413 -31
Branches 1966 1974 +8
============================================
+ Hits 9345 9347 +2
+ Misses 2028 1984 -44
- Partials 1071 1082 +11
Continue to review full report at Codecov.
|
Signed-off-by: Clay Downs <downsrob@amazon.com>
thalurur
approved these changes
May 13, 2022
praveensameneni
approved these changes
May 17, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 17, 2022
* Refactors logging Signed-off-by: Clay Downs <downsrob@amazon.com> * Refactors shrink steps Signed-off-by: Clay Downs <downsrob@amazon.com> * Cleans up cleanup Signed-off-by: Clay Downs <downsrob@amazon.com> * Adds unit tests Signed-off-by: Clay Downs <downsrob@amazon.com> * Fixed detekt issues Signed-off-by: Clay Downs <downsrob@amazon.com> * Fixes unit test Signed-off-by: Clay Downs <downsrob@amazon.com> * Refactors cleanup and fail Signed-off-by: Clay Downs <downsrob@amazon.com> (cherry picked from commit 4f8e722)
downsrob
added a commit
that referenced
this pull request
May 17, 2022
* Refactors logging Signed-off-by: Clay Downs <downsrob@amazon.com> * Refactors shrink steps Signed-off-by: Clay Downs <downsrob@amazon.com> * Cleans up cleanup Signed-off-by: Clay Downs <downsrob@amazon.com> * Adds unit tests Signed-off-by: Clay Downs <downsrob@amazon.com> * Fixed detekt issues Signed-off-by: Clay Downs <downsrob@amazon.com> * Fixes unit test Signed-off-by: Clay Downs <downsrob@amazon.com> * Refactors cleanup and fail Signed-off-by: Clay Downs <downsrob@amazon.com> (cherry picked from commit 4f8e722) Co-authored-by: Clay Downs <downsrob@amazon.com>
wuychn
pushed a commit
to ochprince/index-management
that referenced
this pull request
Mar 16, 2023
…#349) * Refactors logging Signed-off-by: Clay Downs <downsrob@amazon.com> * Refactors shrink steps Signed-off-by: Clay Downs <downsrob@amazon.com> * Cleans up cleanup Signed-off-by: Clay Downs <downsrob@amazon.com> * Adds unit tests Signed-off-by: Clay Downs <downsrob@amazon.com> * Fixed detekt issues Signed-off-by: Clay Downs <downsrob@amazon.com> * Fixes unit test Signed-off-by: Clay Downs <downsrob@amazon.com> * Refactors cleanup and fail Signed-off-by: Clay Downs <downsrob@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#40
Description of changes:
Adds additional unit tests for the shrink action step util functions and refactors the shrink action steps for readability and reduced code duplication. Also fixes a bug where the shrink action would not wait for a copy of each shard to move to the selected node before initiating the shrink.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.