Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

556: Moved _doc_count from transform._doc_count to root of document #558

Conversation

stevanbz
Copy link
Contributor

@stevanbz stevanbz commented Oct 6, 2022

Signed-off-by: Stevan Buzejic buzejic.stevan@gmail.com

Issue #, if available: #556

Description of changes:
Moved _doc_values from transform.doc_values to root of document

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@stevanbz stevanbz requested a review from a team October 6, 2022 20:01
@stevanbz stevanbz force-pushed the bugfix/556-transform-doc-values branch 2 times, most recently from 8aae3e1 to 2195d3c Compare October 6, 2022 20:33
@codecov-commenter
Copy link

Codecov Report

Merging #558 (07da890) into main (943c32b) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 07da890 differs from pull request most recent head 2195d3c. Consider uploading reports for the commit 2195d3c to get more accurate results

@@             Coverage Diff              @@
##               main     #558      +/-   ##
============================================
+ Coverage     75.81%   75.84%   +0.02%     
- Complexity     2480     2483       +3     
============================================
  Files           315      316       +1     
  Lines         14511    14546      +35     
  Branches       2245     2248       +3     
============================================
+ Hits          11002    11032      +30     
+ Misses         2255     2252       -3     
- Partials       1254     1262       +8     
Impacted Files Coverage Δ
...earch/indexmanagement/transform/model/Transform.kt 85.47% <ø> (-0.43%) ⬇️
...nt/indexstatemanagement/model/destination/Chime.kt 55.55% <0.00%> (-22.23%) ⬇️
...exmanagement/indexstatemanagement/SkipExecution.kt 61.29% <0.00%> (-5.38%) ⬇️
...gement/transform/model/ContinuousTransformStats.kt 70.37% <0.00%> (-3.71%) ⬇️
...xmanagement/indexstatemanagement/util/StepUtils.kt 85.39% <0.00%> (-2.25%) ⬇️
.../action/explain/TransportExplainTransformAction.kt 70.78% <0.00%> (-2.25%) ⬇️
...ensearch/indexmanagement/rollup/model/ISMRollup.kt 94.78% <0.00%> (-1.74%) ⬇️
...gement/indexstatemanagement/action/ShrinkAction.kt 70.58% <0.00%> (-1.48%) ⬇️
...anagement/indexstatemanagement/model/Transition.kt 61.64% <0.00%> (-1.37%) ⬇️
.../rollup/action/start/TransportStartRollupAction.kt 71.76% <0.00%> (-1.18%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stevanbz stevanbz force-pushed the bugfix/556-transform-doc-values branch from 2195d3c to e07425c Compare October 7, 2022 06:51
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
@stevanbz stevanbz force-pushed the bugfix/556-transform-doc-values branch from e07425c to 947e90b Compare October 7, 2022 14:51
@Angie-Zhang Angie-Zhang merged commit c908871 into opensearch-project:main Oct 7, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 7, 2022
…558)

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
(cherry picked from commit c908871)
Angie-Zhang pushed a commit that referenced this pull request Oct 13, 2022
…558) (#568)

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
(cherry picked from commit c908871)

Co-authored-by: Stevan Buzejic <30922513+stevanbz@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 11, 2023
…558)

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
(cherry picked from commit c908871)
Angie-Zhang pushed a commit that referenced this pull request Jan 11, 2023
…558) (#661)

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
(cherry picked from commit c908871)

Co-authored-by: Stevan Buzejic <30922513+stevanbz@users.noreply.github.com>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
…pensearch-project#558) (opensearch-project#568)

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
(cherry picked from commit c908871)

Co-authored-by: Stevan Buzejic <30922513+stevanbz@users.noreply.github.com>
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
…pensearch-project#558) (opensearch-project#568)

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
(cherry picked from commit c908871)

Co-authored-by: Stevan Buzejic <30922513+stevanbz@users.noreply.github.com>
Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants