Generalize error message set in model metadata #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mazanec <jmazane@amazon.com>
vamshin
reviewed
Nov 5, 2021
| @@ -149,7 +149,7 @@ private void train(TrainingJob trainingJob) { | |||
|
|
|||
| ModelMetadata modelMetadata = trainingJob.getModel().getModelMetadata(); | |||
| modelMetadata.setState(ModelState.FAILED); | |||
| modelMetadata.setError(ree.getMessage()); | |||
| modelMetadata.setError("Training job execution was rejected. Node's training queue is at capacity."); | |||
There was a problem hiding this comment.
It would be great to have node name also printed. But we can take in future PRs.
There was a problem hiding this comment.
agree. Will look into in future.
Signed-off-by: John Mazanec <jmazane@amazon.com>
VijayanB
approved these changes
Nov 5, 2021
jmazanec15
added
the
Enhancements
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Signed-off-by: John Mazanec <jmazane@amazon.com>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Signed-off-by: John Mazanec <jmazane@amazon.com> Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
Signed-off-by: John Mazanec <jmazane@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change generalizes the error message exposed to user when training fails. Before, we just set the message as the exception. However, this can expose internal details of the service. So, this generalizes the messages.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.