Adding OSB index specification json for lucene hnsw #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
added
Enhancements
jmazanec15
approved these changes
Sep 14, 2022
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
=========================================
Coverage 84.07% 84.07%
Complexity 1021 1021
=========================================
Files 146 146
Lines 4195 4195
Branches 373 373
=========================================
Hits 3527 3527
Misses 492 492
Partials 176 176 ☔ View full report in Codecov by Sentry. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit cfc6c44)
martin-gaievski
pushed a commit
that referenced
this pull request
Sep 15, 2022
martin-gaievski
added a commit
that referenced
this pull request
Sep 28, 2022
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
heemin32
added
v2.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Martin Gaievski gaievski@amazon.com
Description
Gives example of index specification in case one need to use OSB to test lucene knn. We do have similar files fornmslib and faiss engines.
Issues Resolved
Keeping parity between Lucene hnsw and other knn engines
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.