rename tribuo AD algorithm name #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Zhangxunmt
reviewed
Feb 17, 2022
| @@ -8,7 +8,7 @@ | |||
| public enum FunctionName { | |||
| LINEAR_REGRESSION, | |||
| KMEANS, | |||
| ANOMALY_DETECTION, | |||
| AD_LIBSVM, | |||
There was a problem hiding this comment.
I may lack the context - what is the difference between these two names? They represent the same AD algorithm?
There was a problem hiding this comment.
That's to avoid confusion. Tribuo using libSVM to do anomaly detection. The new name is more accurate. So user can distinguish different AD algorithms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yaliang Wu ylwu@amazon.com
Description
Rename tribuo AD algorithm name.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.