Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jacoco result not updated to latest commit issue #3581

Closed
wants to merge 17 commits into from
Closed

Fix jacoco result not updated to latest commit issue #3581

wants to merge 17 commits into from

Conversation

zane-neo
Copy link
Collaborator

Description

Fix jacoco result not updated to latest commit issue

Related Issues

#3580

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zane-neo
Copy link
Collaborator Author

@peterzhuamazon Can you help review this PR? Thanks.

peterzhuamazon
peterzhuamazon previously approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve based on @zane-neo confirming that jacoco file exist in plugin/build/reports/jacoco/test/jacocoTestReport.xml.

Need to open another PR to confirm.

Thanks.

@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 18, 2025 09:00 — with GitHub Actions Failure
@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 18, 2025 09:00 — with GitHub Actions Failure
@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 18, 2025 09:00 — with GitHub Actions Failure
@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 18, 2025 09:35 — with GitHub Actions Failure
@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 18, 2025 09:35 — with GitHub Actions Failure
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 18, 2025 10:53 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 18, 2025 10:53 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 18, 2025 10:53 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 18, 2025 10:53 — with GitHub Actions Inactive
@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 18, 2025 11:54 — with GitHub Actions Failure
@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 18, 2025 11:54 — with GitHub Actions Failure
@zane-neo
add back more test to see if not changing anything in CI workflow the…
63dd86f 
… code coverage is updated automatically or not

Signed-off-by: zane-neo <zaniu@amazon.com>
@zane-neo zane-neo force-pushed the fix-jacoco-latency branch from 83df9e3 to 63dd86f Compare March 18, 2025 13:06
zane-neo added 2 commits March 18, 2025 21:09
@zane-neo
change syntax error
ea857f3 
Signed-off-by: zane-neo <zaniu@amazon.com>
@zane-neo
format code
deaa4a8 
Signed-off-by: zane-neo <zaniu@amazon.com>
@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 18, 2025 13:12 — with GitHub Actions Failure
@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 18, 2025 13:12 — with GitHub Actions Failure
@zane-neo
fix compilation error
e0e39f2 
Signed-off-by: zane-neo <zaniu@amazon.com>
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 19, 2025 02:21 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 19, 2025 02:21 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 19, 2025 02:21 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 19, 2025 02:21 — with GitHub Actions Inactive
@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 19, 2025 03:20 — with GitHub Actions Failure
@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 19, 2025 03:20 — with GitHub Actions Failure
@zane-neo zane-neo closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhuamazon peterzhuamazon peterzhuamazon left review comments

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os is a code owner

@mingshl mingshl Awaiting requested review from mingshl mingshl is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

Assignees
No one assigned
Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zane-neo @peterzhuamazon