Fix model search for deleting connector #3671
Merged
+0
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
dbwiddis
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
dbwiddis
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
dhrubo-os
approved these changes
Mar 19, 2025
zane-neo
approved these changes
Mar 19, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit a381e10)
dhrubo-os
pushed a commit
that referenced
this pull request
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The model search for delete connector incorrectly overwrote the search for connector ID with one for tenant ID.
There is no need to handle tenant ID in searching, as it is handled by the sdk client when tenant awarness is set, see here and here.
Also removed the (redundant) filtering in the search for models in a model group. This properly appended the filter, but as it is handled by the client, is also unnecessary.
Added 41353eb to integ test PR #3516 which will fail until this PR is merged.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.