Adds security IT for new upload and load APIs #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Zhang <xunzh@amazon.com>
ylwu-amzn
reviewed
Nov 4, 2022
| loadModel(mlFullAccessNoIndexAccessClient, mlUploadInput, null); | ||
| } | ||
|
|
||
| public void testLoadModelWithFullAccess() throws IOException { |
There was a problem hiding this comment.
Also add test cases for new unload and profile APIs?
There was a problem hiding this comment.
Yes, let's add them in the next PR
ylwu-amzn
approved these changes
Nov 4, 2022
rbhavna
approved these changes
Nov 4, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
Signed-off-by: Xun Zhang <xunzh@amazon.com> (cherry picked from commit f0cf53f)
ylwu-amzn
pushed a commit
that referenced
this pull request
Nov 4, 2022
b4sjoo
pushed a commit
to b4sjoo/ml-commons
that referenced
this pull request
Dec 2, 2022
Signed-off-by: Xun Zhang <xunzh@amazon.com> Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
b4sjoo
added a commit
that referenced
this pull request
Dec 2, 2022
Signed-off-by: Xun Zhang <xunzh@amazon.com> Signed-off-by: Sicheng Song <sicheng.song@outlook.com> Signed-off-by: Xun Zhang <xunzh@amazon.com> Signed-off-by: Sicheng Song <sicheng.song@outlook.com> Co-authored-by: Xun Zhang <xunzh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xun Zhang xunzh@amazon.com
Description
Adds more security IT test for upload and load APIs.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.