Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release meta issue template for 1.1.1 #1100

Closed
wants to merge 21 commits into from
Closed

Add release meta issue template for 1.1.1 #1100

wants to merge 21 commits into from

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Add release meta issue template for 1.1.1

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon
Add release meta issue template for 1.1.1
187dbcc 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon self-assigned this Nov 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021 •
edited
Loading

Codecov Report

Merging #1100 (3742545) into main (1ea1896) will decrease coverage by 21.77%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##               main    #1100       +/-   ##
=============================================
- Coverage     93.92%   72.15%   -21.78%     
  Complexity       11       11               
=============================================
  Files           127       16      -111     
  Lines          2863       79     -2784     
  Branches         10       10               
=============================================
- Hits           2689       57     -2632     
+ Misses          164       12      -152     
  Partials         10       10
Impacted Files Coverage Δ
src/build_workflow/builders.py
src/ci_workflow/ci_check_lists.py
src/git/git_repository.py
src/manifests/build/build_manifest_1_0.py
src/manifests/build/build_manifest_1_1.py
src/manifests/build_manifest.py
src/manifests/bundle/bundle_manifest_1_0.py
src/manifests/bundle_manifest.py
src/manifests/component_manifest.py
src/manifests/input_manifest.py
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea1896...3742545. Read the comment docs.

@dblock
Copy link
Member

dblock commented Nov 18, 2021

We're not going to run this for all repos right? Just on those included in 1.1.1?

@peterzhuamazon
Copy link
Member Author

We're not going to run this for all repos right? Just on those included in 1.1.1?

Yes.

@peterzhuamazon
Update a dashboards input manifests for 1.1.1
189cc9f 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Add more changes based on comments
484a691 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Hi @dblock @peternied could you take another look at this?
I have addressed your comments with commits.

Thanks.

@dblock
Copy link
Member

dblock commented Nov 19, 2021

Is it ready to merge? Convert from draft?

@peterzhuamazon peterzhuamazon marked this pull request as ready for review November 19, 2021 00:19
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner November 19, 2021 00:19
@peterzhuamazon peterzhuamazon marked this pull request as draft November 19, 2021 00:19
@peterzhuamazon peterzhuamazon marked this pull request as ready for review November 19, 2021 00:20
@peterzhuamazon
Merge branch 'main' of github.com:peterzhuamazon/opensearch-build int…
7f7f9b3 
…o opensearch-release-issues
@peterzhuamazon
Update release yml with dist not ref for reusing old artifacts
20d2536 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Adding more changes to the issue template
32db112 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
More changes to the dashboards 1.1.1 yml manifests
b9bfb21 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Fix the type issue as dashboards is using dist to build patches
8a0a311 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@dblock dblock requested a review from peternied November 30, 2021 23:27
@peterzhuamazon
Merge branch 'main' of github.com:peterzhuamazon/opensearch-build int…
a2d1ebc 
…o opensearch-release-issues
@peterzhuamazon
Correct link to release template here
e09709d 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Tweak reports section so it is build from source
9843d67 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Add more changes to ensure downloading artifacts runs
d44af09 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Add @Property to replace the function call
9b0d361 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Temp comment out the check function to run builds
6ae58c6 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Merged from main
cc7854c 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Revert "Typechecking for manifests (opensearch-project#1224)"
39055c6 
This reverts commit 5820881.
@peterzhuamazon
More changes to make reports plugin build
05b0dcf 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peternied
Copy link
Member

Looks like all kinds of merging happened on this PR that have it messed up, I'd recommend cherry-picking into a fresh branch

peternied
peternied suggested changes Dec 2, 2021
View reviewed changes
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 17 commits and it looks like bad merge resolutions, please rebase/cherry-pick and update this PR

@peterzhuamazon
Merge from main and changes to reports build scripts
8bb2258 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Add opensearch 1.1.1 related input manifest
e1e5818 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
merge from main
fcd8d03 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
More changes to templates for 1.1.1
3742545 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Close this as a lot of changes have been pushed.

@peterzhuamazon peterzhuamazon mentioned this pull request Dec 8, 2021
Merged
1 task
@peterzhuamazon peterzhuamazon deleted the opensearch-release-issues branch February 17, 2022 22:21
@peterzhuamazon peterzhuamazon restored the opensearch-release-issues branch February 17, 2022 22:22
@peterzhuamazon peterzhuamazon deleted the opensearch-release-issues branch May 16, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternied peternied peternied requested changes

@dblock dblock dblock approved these changes

@bbarani bbarani Awaiting requested review from bbarani

Assignees

@peterzhuamazon peterzhuamazon

Labels
cicd release v1.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterzhuamazon @codecov-commenter @dblock @peternied