Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release_template with step to update next release's manifest. #1139

Closed
wants to merge 1 commit into from

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Nov 23, 2021

Signed-off-by: Marc Handalian handalm@amazon.com

Description

Updates the release template with a step to update the next release's manifest.

Issues Resolved

related - opensearch-project/OpenSearch#1317
closes #1140

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sorry, something went wrong.

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Marc Handalian <handalm@amazon.com>
@gaiksaya
Copy link
Member

gaiksaya commented Nov 23, 2021

Should the nightly's be pointing to main as component's ref when a new manifest is created? And then change to 1.3 branch at T-14 days?

@codecov-commenter
Copy link

Codecov Report

Merging #1139 (3bcbd6d) into main (c0490fb) will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1139      +/-   ##
============================================
+ Coverage     93.49%   94.01%   +0.52%     
============================================
  Files           100       92       -8     
  Lines          2551     2489      -62     
  Branches          7        0       -7     
============================================
- Hits           2385     2340      -45     
+ Misses          158      149       -9     
+ Partials          8        0       -8     
Impacted Files Coverage Δ
tests/jenkins/jobs/BuildManifest_Jenkinsfile
tests/jenkins/jobs/InputManifest_Jenkinsfile
tests/jenkins/jobs/Hello_Jenkinsfile
src/jenkins/BuildManifest.groovy
tests/jenkins/jobs/Messages_Jenkinsfile
tests/jenkins/jobs/Vars_Jenkinsfile
src/jenkins/InputManifest.groovy
src/jenkins/Messages.groovy

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0490fb...3bcbd6d. Read the comment docs.

@mch2
Copy link
Member Author

mch2 commented Nov 23, 2021

Should the nightly's be pointing to main of component's ref when a new manifest is created? And then change to 1.3 branch at T-14 days?

That makes sense for major releases but not for minor. If the plugin repo is following the correct branching strategy we could do this for minors as well and set them to (version.x) branch.
@gaiksaya I should have cut this initially as an issue - lets chat on #1140.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this. It's a step in the next release's checklist.

@mch2 mch2 closed this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly bundle builds do not include full bundle until T-14 days to release.
4 participants