Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opensearch-2.0.0.yml #1668

Closed

Conversation

praveensameneni
Copy link
Member

Add common-utils, job-scheduler, alerting

Description

add common-utils, job-scheduler, alerting to build against 2.0

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@praveensameneni praveensameneni requested a review from a team as a code owner February 23, 2022 06:17
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #1668 (063c642) into main (faf26d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1668   +/-   ##
=========================================
  Coverage     94.79%   94.79%           
  Complexity       17       17           
=========================================
  Files           169      169           
  Lines          3536     3536           
  Branches         26       26           
=========================================
  Hits           3352     3352           
  Misses          181      181           
  Partials          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf26d1...063c642. Read the comment docs.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation for yml.

Add common-utils, job-scheduler, alerting

Signed-off-by: praveensameneni <50342543+praveensameneni@users.noreply.github.com>
Signed-off-by: praveensameneni <50342543+praveensameneni@users.noreply.github.com>
Signed-off-by: praveensameneni <samenp@amazon.com>
Signed-off-by: praveensameneni <50342543+praveensameneni@users.noreply.github.com>
@praveensameneni
Copy link
Member Author

@gaiksaya

Fixed the indentation and DCO checks.

Signed-off-by: praveensameneni <50342543+praveensameneni@users.noreply.github.com>
@peterzhuamazon
Copy link
Member

@praveensameneni common-utils fail the check, please ask corresponding owner to fix it before we can proceed.
Thanks.


2022-03-02 18:49:59 INFO     Sanity testing common-utils
2022-03-02 18:49:59 INFO     Executing "git init" in /tmp/tmpn2uax2z6/common-utils
2022-03-02 18:49:59 INFO     Executing "git remote add origin https://github.com/opensearch-project/common-utils.git" in /tmp/tmpn2uax2z6/common-utils
2022-03-02 18:49:59 INFO     Executing "git fetch --depth 1 origin main" in /tmp/tmpn2uax2z6/common-utils
2022-03-02 18:49:59 INFO     Executing "git checkout FETCH_HEAD" in /tmp/tmpn2uax2z6/common-utils
2022-03-02 18:49:59 INFO     Executing "git rev-parse HEAD" in /tmp/tmpn2uax2z6/common-utils
2022-03-02 18:49:59 INFO     Checked out https://github.com/opensearch-project/common-utils.git@main into /tmp/tmpn2uax2z6/common-utils at 710b1f9e337a3a07d65f88b1ec823f1cc4f8cbf4
2022-03-02 18:49:59 INFO     Executing "./gradlew publishToMavenLocal -Dopensearch.version=2.0.0-SNAPSHOT -Dbuild.snapshot=true" in /tmp/tmpn2uax2z6/common-utils
Downloading https://services.gradle.org/distributions/gradle-6.4-all.zip
..........................................................................................................................................

Welcome to Gradle 6.4!

Here are the highlights of this release:
 - Support for building, testing and running Java Modules
 - Precompiled script plugins for Groovy DSL
 - Single dependency lock file per project

For more details see https://docs.gradle.org/6.4/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

* Where:
Build file '/tmp/tmpn2uax2z6/common-utils/build.gradle' line: 59

* What went wrong:
A problem occurred evaluating root project 'common-utils'.
> Failed to apply plugin [class 'com.github.jengelman.gradle.plugins.shadow.ShadowBasePlugin']
   > This version of Shadow supports Gradle 7.0+ only. Please upgrade.

@lezzago
Copy link
Member

lezzago commented Mar 3, 2022

@peterzhuamazon, can you rerun the tests? Common-utils has been upgraded now: opensearch-project/common-utils#122

@peterzhuamazon
Copy link
Member

@peterzhuamazon, can you rerun the tests? Common-utils has been upgraded now: opensearch-project/common-utils#122

rerun now.

@peterzhuamazon
Copy link
Member

There are some weird issues related to ci script, security trying to pull an incorrect branch, not sure if it is caused by things like not rebase on main, checking.

@peterzhuamazon
Copy link
Member

@praveensameneni JS is not running on 2.0.0, please check

2022-03-03 01:51:54 INFO     Checked out https://github.com/opensearch-project/job-scheduler.git@main into /tmp/tmpi7dl8iwh/job-scheduler at d232cbc3b179caccb7216ca004c4c9ce521d109d
2022-03-03 01:51:54 INFO     Executing "./gradlew properties -Dopensearch.version=2.0.0-SNAPSHOT -Dbuild.snapshot=true" in /tmp/tmpi7dl8iwh/job-scheduler

FAILURE: Build failed with an exception.

* Where:
Build file '/tmp/tmpi7dl8iwh/job-scheduler/build.gradle' line: 28

* What went wrong:
A problem occurred evaluating root project 'opensearch-job-scheduler'.
> Failed to apply plugin class 'org.opensearch.gradle.info.GlobalBuildInfoPlugin'.
   > Could not create plugin of type 'GlobalBuildInfoPlugin'.
      > Could not generate a decorated class for type GlobalBuildInfoPlugin.
         > org/gradle/internal/jvm/inspection/JvmInstallationMetadata

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org/

BUILD FAILED in 19s
2022-03-03 01:52:15 ERROR    CI Manifest check failed
Traceback (most recent call last):
  File "./src/run_ci.py", line 25, in <module>
    sys.exit(main())
  File "./src/run_ci.py", line 21, in main
    CiManifests.from_file(args.manifest, args).check()
  File "/home/runner/work/opensearch-build/opensearch-build/src/ci_workflow/ci_manifest.py", line 21, in check
    self.__check__()
  File "/home/runner/work/opensearch-build/opensearch-build/src/ci_workflow/ci_input_manifest.py", line 36, in __check__
    ci_check_list.check()
  File "/home/runner/work/opensearch-build/opensearch-build/src/ci_workflow/ci_check_list_source.py", line 43, in check
    instance = klass(self.component, self.git_repo, self.target, check.args)
  File "/home/runner/work/opensearch-build/opensearch-build/src/ci_workflow/ci_check_gradle_properties.py", line 19, in __init__
    self.properties = self.__get_properties()
  File "/home/runner/work/opensearch-build/opensearch-build/src/ci_workflow/ci_check_gradle_properties.py", line 30, in __get_properties
    return PropertiesFile(self.git_repo.output(cmd))
  File "/home/runner/work/opensearch-build/opensearch-build/src/git/git_repository.py", line 78, in output
    return subprocess.check_output(command, cwd=cwd, shell=True).decode().strip()
  File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/subprocess.py", line 411, in check_output
    **kwargs).stdout
  File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/subprocess.py", line 512, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command './gradlew properties -Dopensearch.version=2.0.0-SNAPSHOT -Dbuild.snapshot=true' returned non-zero exit status 1.
Error: Process completed with exit code 1.

Thanks.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member

New error due to alerting plugin failures:
opensearch-project/alerting#351

@dblock
Copy link
Member

dblock commented Mar 15, 2022

I'm going to close this since nobody is working on it. Reopen a PR when there's a successful alerting 2.0 build.

@dblock dblock closed this Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants