Add crane/krane as part of the executable binary in docker-builder image #3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhuamazon
added
enhancement
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Divyaasm
approved these changes
May 8, 2023
rishabh6788
approved these changes
May 8, 2023
peterzhuamazon
changed the title
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
force-pushed
the
add_crane_permission_dockerbuilder
branch
from
42e7588 to
b6ef7e1
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #3490 +/- ##
=======================================
Coverage 91.16% 91.16%
=======================================
Files 181 181
Lines 5340 5340
=======================================
Hits 4868 4868
Misses 472 472 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add crane/krane as part of the executable binary in docker-builder image
Issues Resolved
#3386
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.