-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix make_model_config_json function #188
Merged
dhrubo-os
merged 14 commits into
opensearch-project:main
from
thanawan-atc:make-model-config-json
Jul 7, 2023
Merged
Fix make_model_config_json function #188
dhrubo-os
merged 14 commits into
opensearch-project:main
from
thanawan-atc:make-model-config-json
Jul 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
dhrubo-os
reviewed
Jul 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #188 +/- ##
==========================================
+ Coverage 90.81% 90.96% +0.15%
==========================================
Files 37 37
Lines 4050 4073 +23
==========================================
+ Hits 3678 3705 +27
+ Misses 372 368 -4
|
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
dhrubo-os
reviewed
Jul 6, 2023
dhrubo-os
reviewed
Jul 6, 2023
dhrubo-os
reviewed
Jul 6, 2023
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
36cfeeb
to
35fca4e
Compare
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
1490c7d
to
5ff266f
Compare
Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
dhrubo-os
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding all those tests.
b4sjoo
approved these changes
Jul 7, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
* Improve make_model_config_json function Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Fix linting issues Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add unittest Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Fix bug Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Minor Edit + Add more tests Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Fix test Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct typos Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Increase test coverage Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Increase test coverage (2) Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Increase test coverage (3) Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Remove redundant line Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit 13149e8)
dhrubo-os
pushed a commit
that referenced
this pull request
Jul 10, 2023
* Improve make_model_config_json function Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Fix linting issues Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add CHANGELOG.md Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Add unittest Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct linting Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Fix bug Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Minor Edit + Add more tests Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Fix test Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Correct typos Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Increase test coverage Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Increase test coverage (2) Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Increase test coverage (3) Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> * Remove redundant line Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> --------- Signed-off-by: Thanawan Atchariyachanvanit <latchari@amazon.com> (cherry picked from commit 13149e8) Co-authored-by: Thanawan Atchariyachanvanit <latchari@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
make_model_config_json
function so that we can trace the model without having to create the model config file by ourselves.Have been tested on tracing the following models in TorchScript and ONNX format:
sentence-transformers/msmarco-distilbert-base-tas-b
sentence-transformers/multi-qa-MiniLM-L6-cos-v1
sentence-transformers/all-MiniLM-L12-v2
sentence-transformers/multi-qa-mpnet-base-dot-v1
Issues Resolved
model_format
pooling_mode
from Huggingfacenormalize_result
from Huggingfaceembedding_dimension
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.