-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#351 - Add support for ML-Common's stats API #354
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
- Coverage 91.53% 90.12% -1.41%
==========================================
Files 42 43 +1
Lines 4395 4417 +22
==========================================
- Hits 4023 3981 -42
- Misses 372 436 +64 ☔ View full report in Codecov by Sentry. |
Signed-off-by: kalyanr <kalyan.ben10@live.com>
Signed-off-by: kalyanr <kalyan.ben10@live.com>
@dhrubo-os , it seems like Stats API doesn't work for 2.7.0 . Its been failing with the following error message
` But, its working fine for 2.11.0. Hence, I skipped the stats test for 2.7.0. Is this ok? |
@dhrubo-os , were you able to find examples for the request body that can be sent to stats api? |
…/ml-commons-stats Signed-off-by: kalyanr <kalyan.ben10@live.com>
…ch-py-ml into kalyan/ml-commons-stats Signed-off-by: kalyanr <kalyan.ben10@live.com>
Signed-off-by: kalyanr <kalyan.ben10@live.com>
Add test? Integration test failing. |
updated it |
Can you also please update the issue description with more details like which examples your tried so far to do the functional test? |
Signed-off-by: kalyanr <kalyan.ben10@live.com>
7fd63f8
to
dab84e3
Compare
Signed-off-by: kalyanr <kalyan.ben10@live.com>
Could you please resolve the conflict? |
…ch-py-ml into kalyan/ml-commons-stats Signed-off-by: kalyanr <kalyan.ben10@live.com>
Signed-off-by: kalyanr <kalyan.ben10@live.com>
2761411
to
085c008
Compare
Description
Adds support for Stats API
Issues Resolved
closes #351
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.