update upload-artifact and download-artifact to v4 #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl
requested review from
AMoo-Miki,
bandinib-amzn,
ashwin-pc,
joshuarrrr and
virajsanghvi
as code owners
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
|
Nice! Are these artifacts only used in the CI/CD? Just wondering to make sure there aren't unintended side effects that aren't covered by our PR checks. |
Also curious on this question |
ashwin-pc
approved these changes
Feb 17, 2025
|
I dont think they are used anywhere else today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting January 30th, 2025, GitHub Actions customers will no longer be able to use v3 of actions/upload-artifact or actions/download-artifact.
This PR updates
actions/upload-artifactfrom v3 to v4.Issues Resolved
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.