Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create detectors UI pages #15

Merged

Conversation

amsiglan
Copy link
Collaborator

Description

Implemented the UI pages for create detector work flow. The UI uses dummy data and will be connected to backend in followup PRs.

This PR completes most of work outlined in Create detection flow

Detectors list
Define detector page
Configure field mappings page
Set up alerts page

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
@amsiglan amsiglan requested a review from a team October 13, 2022 05:01
@amsiglan amsiglan changed the title Amsiglan/create detectors UI Create detectors UI pages Oct 13, 2022
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Copy link
Collaborator

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor comment that isn't blocking this merge.

@amsiglan amsiglan merged commit e109f88 into opensearch-project:main Oct 15, 2022
@amsiglan amsiglan deleted the amsiglan/create-detectors-UI branch October 20, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants