Ftr 142 create detector desc text below header #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sinisa Andric <johnsie@gmail.com>
Signed-off-by: Sinisa Andric <johnsie@gmail.com>
AWSHurneyt
reviewed
Nov 22, 2022
.../pages/CreateDetector/components/DefineDetector/components/DetectionRules/DetectionRules.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Sinisa Andric <johnsie@gmail.com>
amsiglan
reviewed
Nov 22, 2022
...c/pages/CreateDetector/components/ConfigureFieldMapping/containers/ConfigureFieldMapping.tsx
Outdated
Show resolved
Hide resolved
amsiglan
reviewed
Nov 22, 2022
.../pages/CreateDetector/components/DefineDetector/components/DetectionRules/DetectionRules.tsx
Outdated
Show resolved
Hide resolved
amsiglan
reviewed
Nov 22, 2022
public/pages/CreateDetector/components/DefineDetector/containers/DefineDetector.tsx
Outdated
Show resolved
Hide resolved
amsiglan
reviewed
Nov 22, 2022
Signed-off-by: Sinisa Andric <johnsie@gmail.com>
phestecAMZN
reviewed
Nov 22, 2022
.../pages/CreateDetector/components/DefineDetector/components/DetectionRules/DetectionRules.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Sinisa Andric <johnsie@gmail.com>
AWSHurneyt
approved these changes
Nov 23, 2022
phestecAMZN
approved these changes
Nov 23, 2022
amsiglan
approved these changes
Nov 23, 2022
|
This should be related to issue #142. |
Signed-off-by: Sinisa Andric <johnsie@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 5, 2022
* Add description text below header Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Update subtitles as per design Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Update ContentPanel subtitleText Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Fix PR remarks Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Fix subtitle size Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Cypress test fix Signed-off-by: Sinisa Andric <johnsie@gmail.com> Signed-off-by: Sinisa Andric <johnsie@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 17818ee)
AWSHurneyt
pushed a commit
that referenced
this pull request
Dec 5, 2022
* Add description text below header Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Update subtitles as per design Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Update ContentPanel subtitleText Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Fix PR remarks Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Fix subtitle size Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Cypress test fix Signed-off-by: Sinisa Andric <johnsie@gmail.com> Signed-off-by: Sinisa Andric <johnsie@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 17818ee) Co-authored-by: Sinisa Andric <johnsie@gmail.com>
jovancacvetkovic
pushed a commit
to jovancacvetkovic/security-analytics-dashboards-plugin
that referenced
this pull request
Dec 7, 2022
* Add description text below header Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Update subtitles as per design Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Update ContentPanel subtitleText Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Fix PR remarks Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Fix subtitle size Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Cypress test fix Signed-off-by: Sinisa Andric <johnsie@gmail.com> Signed-off-by: Sinisa Andric <johnsie@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
… (opensearch-project#197) * Add description text below header Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Update subtitles as per design Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Update ContentPanel subtitleText Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Fix PR remarks Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Fix subtitle size Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Cypress test fix Signed-off-by: Sinisa Andric <johnsie@gmail.com> Signed-off-by: Sinisa Andric <johnsie@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 17818ee) Co-authored-by: Sinisa Andric <johnsie@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
… (opensearch-project#197) * Add description text below header Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Update subtitles as per design Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Update ContentPanel subtitleText Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Fix PR remarks Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Fix subtitle size Signed-off-by: Sinisa Andric <johnsie@gmail.com> * Cypress test fix Signed-off-by: Sinisa Andric <johnsie@gmail.com> Signed-off-by: Sinisa Andric <johnsie@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 17818ee) Co-authored-by: Sinisa Andric <johnsie@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes description text and subtitles in Create Detector flow, as per design.
Issues Resolved
#142
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.