Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Components Snapshot Tests #218

Conversation

paladin-tech
Copy link
Contributor

Signed-off-by: Sinisa Andric johnsie@gmail.com

Description

We need to improve unit test coverage for our code base.

Issues Resolved

#217

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sinisa Andric <johnsie@gmail.com>
@paladin-tech paladin-tech requested a review from a team December 13, 2022 19:57
@amsiglan amsiglan merged commit 9136293 into opensearch-project:main Dec 17, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 17, 2022
Signed-off-by: Sinisa Andric <johnsie@gmail.com>

Signed-off-by: Sinisa Andric <johnsie@gmail.com>
(cherry picked from commit 9136293)
amsiglan pushed a commit that referenced this pull request Dec 19, 2022
Signed-off-by: Sinisa Andric <johnsie@gmail.com>

Signed-off-by: Sinisa Andric <johnsie@gmail.com>
(cherry picked from commit 9136293)

Co-authored-by: Sinisa Andric <johnsie@gmail.com>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…-project#234)

Signed-off-by: Sinisa Andric <johnsie@gmail.com>

Signed-off-by: Sinisa Andric <johnsie@gmail.com>
(cherry picked from commit 9136293)

Co-authored-by: Sinisa Andric <johnsie@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…-project#234)

Signed-off-by: Sinisa Andric <johnsie@gmail.com>

Signed-off-by: Sinisa Andric <johnsie@gmail.com>
(cherry picked from commit 9136293)

Co-authored-by: Sinisa Andric <johnsie@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants