Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle all rules button on detector edit page #239

Conversation

djindjic
Copy link
Contributor

@djindjic djindjic commented Dec 19, 2022

Description

Same toggling rules button as present on detector create flow

Issues Resolved

Closed #122

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
@djindjic djindjic requested a review from a team December 19, 2022 20:41
@djindjic
Copy link
Contributor Author

Screen.Recording.2022-12-19.at.9.48.51.PM.mov

@amsiglan amsiglan merged commit 24a5dab into opensearch-project:main Dec 21, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2022
* toggle all rules button on detector edit page

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* adding toggle all - adds hidden button into table

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
(cherry picked from commit 24a5dab)
amsiglan pushed a commit that referenced this pull request Dec 21, 2022
* toggle all rules button on detector edit page

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* adding toggle all - adds hidden button into table

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
(cherry picked from commit 24a5dab)

Co-authored-by: Aleksandar Djindjic <djindjic@gmail.com>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
opensearch-project#251)

* toggle all rules button on detector edit page

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* adding toggle all - adds hidden button into table

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
(cherry picked from commit 24a5dab)

Co-authored-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
opensearch-project#251)

* toggle all rules button on detector edit page

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* adding toggle all - adds hidden button into table

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
(cherry picked from commit 24a5dab)

Co-authored-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add enable/disable all rules button to edit detector workflow
3 participants