Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress checking on rule YAML content #248

Conversation

djindjic
Copy link
Contributor

@djindjic djindjic commented Dec 21, 2022

Description

Reuse same way of code block testing as we have in alerts cypress test

Issues Resolved

Closes #208

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
@djindjic djindjic requested a review from a team December 21, 2022 17:02
@djindjic djindjic changed the title check yaml rule content Cypress checking on rule YAML content Dec 21, 2022
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
@amsiglan amsiglan merged commit c6d5dbe into opensearch-project:main Dec 21, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-248-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c6d5dbe9fd4e9df3e785dea4c75e6574246f1a0f
# Push it to GitHub
git push --set-upstream origin backport/backport-248-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-248-to-2.x.

amsiglan added a commit that referenced this pull request Jan 9, 2023
* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated latest code from the main branch

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated integration test to latest from main

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Aleksandar Djindjic <djindjic@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…opensearch-project#248, opensearch-project#261 (opensearch-project#287)

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated latest code from the main branch

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated integration test to latest from main

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Aleksandar Djindjic <djindjic@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…opensearch-project#248, opensearch-project#261 (opensearch-project#287)

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* resolved conflicts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated latest code from the main branch

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated integration test to latest from main

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Aleksandar Djindjic <djindjic@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Cypress testing rule edit enhancement
3 participants