Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] More validations on YAML rule editor #279

Conversation

djindjic
Copy link
Contributor

@djindjic djindjic commented Dec 29, 2022

Issues Resolved

Closes #214 #207

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
@djindjic djindjic requested a review from a team December 29, 2022 19:48
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
@djindjic djindjic changed the title [WIP] More validations on YAML rule editor [FEATURE] More validations on YAML rule editor Dec 30, 2022
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
@djindjic
Copy link
Contributor Author

@amsiglan I've addressed Ming's UX improvement points in this PR

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
@amsiglan amsiglan merged commit 6da7c82 into opensearch-project:main Jan 9, 2023
@amsiglan
Copy link
Collaborator

amsiglan commented Jan 9, 2023

The windows cypress test failure was due to a slower loading time and unrelated to the changes made in this PR, hence it was okay to merge the changes.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-279-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6da7c8298c0ae499750a4c50f27f532a2726d282
# Push it to GitHub
git push --set-upstream origin backport/backport-279-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-279-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] More inline validations on YAML rule editor
3 participants