-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] More validations on YAML rule editor #279
[FEATURE] More validations on YAML rule editor #279
Conversation
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
...s/Rules/components/RuleEditor/components/YamlRuleEditorComponent/YamlRuleEditorComponent.tsx
Show resolved
Hide resolved
...s/Rules/components/RuleEditor/components/YamlRuleEditorComponent/YamlRuleEditorComponent.tsx
Show resolved
Hide resolved
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
@amsiglan I've addressed Ming's UX improvement points in this PR |
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
The windows cypress test failure was due to a slower loading time and unrelated to the changes made in this PR, hence it was okay to merge the changes. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-279-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6da7c8298c0ae499750a4c50f27f532a2726d282
# Push it to GitHub
git push --set-upstream origin backport/backport-279-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Issues Resolved
Closes #214 #207
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.