Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules refactor #55

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Conversation

amsiglan
Copy link
Collaborator

@amsiglan amsiglan commented Nov 4, 2022

Description

This PR simplifies the entire Rules code and matches the UI pages to the desired mocks.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
@amsiglan amsiglan requested a review from a team November 4, 2022 04:18
Copy link
Contributor

@phestecAMZN phestecAMZN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, as usual I learned from it. Did not spot any issues.

@AWSHurneyt AWSHurneyt merged commit 8d3eac1 into opensearch-project:main Nov 4, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-55-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8d3eac139f5a0e63ae344dd4d0133a5a411ff24a
# Push it to GitHub
git push --set-upstream origin backport/backport-55-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport/backport-55-to-2.4.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-55-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8d3eac139f5a0e63ae344dd4d0133a5a411ff24a
# Push it to GitHub
git push --set-upstream origin backport/backport-55-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-55-to-2.x.

AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Nov 4, 2022
* rewrote rules pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted changed

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit that referenced this pull request Nov 4, 2022
…ck. (#57)

* Add unit test CI (#34)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adding shared utils, interfaces, client services (#35)

* shared utils, interfaces, client services

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated visualization code to use security compliant parsing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Overview UI page updates (#37)

* merged latest Overview page

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* minor refactor

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added/updated service wrappers used for making REST calls to security analytics backend plugin (#36)

* added/updated service wrappers

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated create detector UX (#39)

* updated create detector ux

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unused code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* added detectors view/edit ux (#40)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated main and rules pages (#41)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated alerts and findings UI pages (#38)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Rules refactor (#55)

* rewrote rules pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted changed

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (#56)

* Refactored display text on flyout accordions based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector field mapping edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector rule edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactor flyout to have links to detector details and rules pages.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented toast notifications for failed and successful API calls.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fixedimport issues (#58)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: Amardeepsingh <114732919+amsiglan@users.noreply.github.com>
Co-authored-by: Amardeepsingh <amardeep7194@gmail.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 4, 2022
…ck. (#57)

* Add unit test CI (#34)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adding shared utils, interfaces, client services (#35)

* shared utils, interfaces, client services

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated visualization code to use security compliant parsing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Overview UI page updates (#37)

* merged latest Overview page

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* minor refactor

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added/updated service wrappers used for making REST calls to security analytics backend plugin (#36)

* added/updated service wrappers

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated create detector UX (#39)

* updated create detector ux

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unused code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* added detectors view/edit ux (#40)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated main and rules pages (#41)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated alerts and findings UI pages (#38)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Rules refactor (#55)

* rewrote rules pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted changed

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (#56)

* Refactored display text on flyout accordions based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector field mapping edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector rule edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactor flyout to have links to detector details and rules pages.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented toast notifications for failed and successful API calls.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fixedimport issues (#58)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: Amardeepsingh <114732919+amsiglan@users.noreply.github.com>
Co-authored-by: Amardeepsingh <amardeep7194@gmail.com>
(cherry picked from commit 674ff1c)
phestecAMZN pushed a commit that referenced this pull request Nov 4, 2022
…ck. (#57) (#63)

* Add unit test CI (#34)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adding shared utils, interfaces, client services (#35)

* shared utils, interfaces, client services

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated visualization code to use security compliant parsing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Overview UI page updates (#37)

* merged latest Overview page

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* minor refactor

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added/updated service wrappers used for making REST calls to security analytics backend plugin (#36)

* added/updated service wrappers

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated create detector UX (#39)

* updated create detector ux

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unused code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* added detectors view/edit ux (#40)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated main and rules pages (#41)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated alerts and findings UI pages (#38)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Rules refactor (#55)

* rewrote rules pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted changed

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (#56)

* Refactored display text on flyout accordions based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector field mapping edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector rule edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactor flyout to have links to detector details and rules pages.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented toast notifications for failed and successful API calls.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fixedimport issues (#58)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: Amardeepsingh <114732919+amsiglan@users.noreply.github.com>
Co-authored-by: Amardeepsingh <amardeep7194@gmail.com>
(cherry picked from commit 674ff1c)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit that referenced this pull request Nov 4, 2022
…ck. (#68)

* Add unit test CI (#34) (#42)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
(cherry picked from commit d05c238)

Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>

* [Backport 2.x] Backporting several PRs to 2.x that failed the DCO check. (#57)

* Add unit test CI (#34)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adding shared utils, interfaces, client services (#35)

* shared utils, interfaces, client services

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated visualization code to use security compliant parsing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Overview UI page updates (#37)

* merged latest Overview page

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* minor refactor

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added/updated service wrappers used for making REST calls to security analytics backend plugin (#36)

* added/updated service wrappers

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated create detector UX (#39)

* updated create detector ux

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unused code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* added detectors view/edit ux (#40)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated main and rules pages (#41)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated alerts and findings UI pages (#38)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Rules refactor (#55)

* rewrote rules pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted changed

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (#56)

* Refactored display text on flyout accordions based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector field mapping edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector rule edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactor flyout to have links to detector details and rules pages.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented toast notifications for failed and successful API calls.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fixedimport issues (#58)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: Amardeepsingh <114732919+amsiglan@users.noreply.github.com>
Co-authored-by: Amardeepsingh <amardeep7194@gmail.com>

* Drafted 2.4 release notes. (#65) (#66)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit a985878)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: Amardeepsingh <114732919+amsiglan@users.noreply.github.com>
Co-authored-by: Amardeepsingh <amardeep7194@gmail.com>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Nov 5, 2022
* rewrote rules pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted changed

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit that referenced this pull request Nov 5, 2022
* Add unit test CI (#34)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adding shared utils, interfaces, client services (#35)

* shared utils, interfaces, client services

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated visualization code to use security compliant parsing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Overview UI page updates (#37)

* merged latest Overview page

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* minor refactor

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added/updated service wrappers used for making REST calls to security analytics backend plugin (#36)

* added/updated service wrappers

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated create detector UX (#39)

* updated create detector ux

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unused code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* added detectors view/edit ux (#40)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated main and rules pages (#41)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated alerts and findings UI pages (#38)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Rules refactor (#55)

* rewrote rules pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted changed

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (#56)

* Refactored display text on flyout accordions based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector field mapping edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector rule edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactor flyout to have links to detector details and rules pages.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented toast notifications for failed and successful API calls.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fixedimport issues (#58)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Redirect to rules page when payload empty for edit or duplicate pages; Improved import page (#59)

* redirect to rules page when payload empty for edit or duplicate pages; import page improvements

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* added toast

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* refactored overview

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added some infrastructure to run cypress tests. (#60)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Drafted 2.4 release notes. (#65)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added toast notifications for failure cases in rule creation/edit (#70)

* added toast notifications for failure

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated toasts logic

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added experimental indicator; fixed edit detector pages (#71)

* added experimental indicator; fixed edit detector pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* fixed links for cancel and save on edit alerts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated link, breadcrumbs; fixed issues related to api calls

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* edited link to forum

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug impacting redirection to monitor details page after creating a monitor. (#72)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented integration test for create rule workflow. (#75)

* Added some infrastructure to run cypress tests.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented integration test for create rule workflow.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: Amardeepsingh <114732919+amsiglan@users.noreply.github.com>
Co-authored-by: Amardeepsingh <amardeep7194@gmail.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 5, 2022
* Add unit test CI (#34)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adding shared utils, interfaces, client services (#35)

* shared utils, interfaces, client services

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated visualization code to use security compliant parsing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Overview UI page updates (#37)

* merged latest Overview page

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* minor refactor

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added/updated service wrappers used for making REST calls to security analytics backend plugin (#36)

* added/updated service wrappers

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated create detector UX (#39)

* updated create detector ux

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unused code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* added detectors view/edit ux (#40)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated main and rules pages (#41)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated alerts and findings UI pages (#38)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Rules refactor (#55)

* rewrote rules pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted changed

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (#56)

* Refactored display text on flyout accordions based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector field mapping edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector rule edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactor flyout to have links to detector details and rules pages.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented toast notifications for failed and successful API calls.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fixedimport issues (#58)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Redirect to rules page when payload empty for edit or duplicate pages; Improved import page (#59)

* redirect to rules page when payload empty for edit or duplicate pages; import page improvements

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* added toast

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* refactored overview

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added some infrastructure to run cypress tests. (#60)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Drafted 2.4 release notes. (#65)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added toast notifications for failure cases in rule creation/edit (#70)

* added toast notifications for failure

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated toasts logic

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added experimental indicator; fixed edit detector pages (#71)

* added experimental indicator; fixed edit detector pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* fixed links for cancel and save on edit alerts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated link, breadcrumbs; fixed issues related to api calls

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* edited link to forum

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug impacting redirection to monitor details page after creating a monitor. (#72)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented integration test for create rule workflow. (#75)

* Added some infrastructure to run cypress tests.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented integration test for create rule workflow.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: Amardeepsingh <114732919+amsiglan@users.noreply.github.com>
Co-authored-by: Amardeepsingh <amardeep7194@gmail.com>
(cherry picked from commit ab8f30d)
AWSHurneyt added a commit that referenced this pull request Nov 5, 2022
* Add unit test CI (#34)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adding shared utils, interfaces, client services (#35)

* shared utils, interfaces, client services

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated visualization code to use security compliant parsing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Overview UI page updates (#37)

* merged latest Overview page

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* minor refactor

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added/updated service wrappers used for making REST calls to security analytics backend plugin (#36)

* added/updated service wrappers

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated create detector UX (#39)

* updated create detector ux

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unused code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* added detectors view/edit ux (#40)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated main and rules pages (#41)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated alerts and findings UI pages (#38)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Rules refactor (#55)

* rewrote rules pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted changed

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (#56)

* Refactored display text on flyout accordions based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector field mapping edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector rule edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactor flyout to have links to detector details and rules pages.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented toast notifications for failed and successful API calls.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fixedimport issues (#58)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Redirect to rules page when payload empty for edit or duplicate pages; Improved import page (#59)

* redirect to rules page when payload empty for edit or duplicate pages; import page improvements

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* added toast

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* refactored overview

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added some infrastructure to run cypress tests. (#60)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Drafted 2.4 release notes. (#65)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added toast notifications for failure cases in rule creation/edit (#70)

* added toast notifications for failure

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated toasts logic

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added experimental indicator; fixed edit detector pages (#71)

* added experimental indicator; fixed edit detector pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* fixed links for cancel and save on edit alerts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated link, breadcrumbs; fixed issues related to api calls

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* edited link to forum

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug impacting redirection to monitor details page after creating a monitor. (#72)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented integration test for create rule workflow. (#75)

* Added some infrastructure to run cypress tests.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented integration test for create rule workflow.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: Amardeepsingh <114732919+amsiglan@users.noreply.github.com>
Co-authored-by: Amardeepsingh <amardeep7194@gmail.com>
(cherry picked from commit ab8f30d)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…ck. (opensearch-project#57)

* Add unit test CI (opensearch-project#34)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adding shared utils, interfaces, client services (opensearch-project#35)

* shared utils, interfaces, client services

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated visualization code to use security compliant parsing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Overview UI page updates (opensearch-project#37)

* merged latest Overview page

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* minor refactor

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added/updated service wrappers used for making REST calls to security analytics backend plugin (opensearch-project#36)

* added/updated service wrappers

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated create detector UX (opensearch-project#39)

* updated create detector ux

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unused code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* added detectors view/edit ux (opensearch-project#40)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated main and rules pages (opensearch-project#41)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated alerts and findings UI pages (opensearch-project#38)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Rules refactor (opensearch-project#55)

* rewrote rules pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted changed

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (opensearch-project#56)

* Refactored display text on flyout accordions based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector field mapping edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector rule edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactor flyout to have links to detector details and rules pages.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented toast notifications for failed and successful API calls.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fixedimport issues (opensearch-project#58)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: Amardeepsingh <114732919+amsiglan@users.noreply.github.com>
Co-authored-by: Amardeepsingh <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
* Add unit test CI (opensearch-project#34)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adding shared utils, interfaces, client services (opensearch-project#35)

* shared utils, interfaces, client services

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated visualization code to use security compliant parsing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Overview UI page updates (opensearch-project#37)

* merged latest Overview page

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* minor refactor

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added/updated service wrappers used for making REST calls to security analytics backend plugin (opensearch-project#36)

* added/updated service wrappers

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated create detector UX (opensearch-project#39)

* updated create detector ux

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unused code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* added detectors view/edit ux (opensearch-project#40)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated main and rules pages (opensearch-project#41)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated alerts and findings UI pages (opensearch-project#38)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Rules refactor (opensearch-project#55)

* rewrote rules pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted changed

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (opensearch-project#56)

* Refactored display text on flyout accordions based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector field mapping edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector rule edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactor flyout to have links to detector details and rules pages.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented toast notifications for failed and successful API calls.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fixedimport issues (opensearch-project#58)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Redirect to rules page when payload empty for edit or duplicate pages; Improved import page (opensearch-project#59)

* redirect to rules page when payload empty for edit or duplicate pages; import page improvements

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* added toast

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* refactored overview

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added some infrastructure to run cypress tests. (opensearch-project#60)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Drafted 2.4 release notes. (opensearch-project#65)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added toast notifications for failure cases in rule creation/edit (opensearch-project#70)

* added toast notifications for failure

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated toasts logic

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added experimental indicator; fixed edit detector pages (opensearch-project#71)

* added experimental indicator; fixed edit detector pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* fixed links for cancel and save on edit alerts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated link, breadcrumbs; fixed issues related to api calls

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* edited link to forum

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug impacting redirection to monitor details page after creating a monitor. (opensearch-project#72)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented integration test for create rule workflow. (opensearch-project#75)

* Added some infrastructure to run cypress tests.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented integration test for create rule workflow.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: Amardeepsingh <114732919+amsiglan@users.noreply.github.com>
Co-authored-by: Amardeepsingh <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…ck. (opensearch-project#57)

* Add unit test CI (opensearch-project#34)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adding shared utils, interfaces, client services (opensearch-project#35)

* shared utils, interfaces, client services

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated visualization code to use security compliant parsing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Overview UI page updates (opensearch-project#37)

* merged latest Overview page

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* minor refactor

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added/updated service wrappers used for making REST calls to security analytics backend plugin (opensearch-project#36)

* added/updated service wrappers

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated create detector UX (opensearch-project#39)

* updated create detector ux

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unused code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* added detectors view/edit ux (opensearch-project#40)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated main and rules pages (opensearch-project#41)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated alerts and findings UI pages (opensearch-project#38)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Rules refactor (opensearch-project#55)

* rewrote rules pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted changed

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (opensearch-project#56)

* Refactored display text on flyout accordions based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector field mapping edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector rule edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactor flyout to have links to detector details and rules pages.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented toast notifications for failed and successful API calls.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fixedimport issues (opensearch-project#58)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: Amardeepsingh <114732919+amsiglan@users.noreply.github.com>
Co-authored-by: Amardeepsingh <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
* Add unit test CI (opensearch-project#34)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adding shared utils, interfaces, client services (opensearch-project#35)

* shared utils, interfaces, client services

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated visualization code to use security compliant parsing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Overview UI page updates (opensearch-project#37)

* merged latest Overview page

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* minor refactor

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added/updated service wrappers used for making REST calls to security analytics backend plugin (opensearch-project#36)

* added/updated service wrappers

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated create detector UX (opensearch-project#39)

* updated create detector ux

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unused code

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* added detectors view/edit ux (opensearch-project#40)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated main and rules pages (opensearch-project#41)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated alerts and findings UI pages (opensearch-project#38)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Rules refactor (opensearch-project#55)

* rewrote rules pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* removed unwanted changed

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed edit page refresh bug. Implemented toast notifications. Refactored some components based on feedback. (opensearch-project#56)

* Refactored display text on flyout accordions based on UX feedback.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector field mapping edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug that caused the detector rule edit page to crash on refresh.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added field validation to create detector flow. Refactored default message subject and body, and added a button to populate the body with alert condition selections.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactor flyout to have links to detector details and rules pages.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented toast notifications for failed and successful API calls.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fixedimport issues (opensearch-project#58)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Redirect to rules page when payload empty for edit or duplicate pages; Improved import page (opensearch-project#59)

* redirect to rules page when payload empty for edit or duplicate pages; import page improvements

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* added toast

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* refactored overview

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added some infrastructure to run cypress tests. (opensearch-project#60)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Drafted 2.4 release notes. (opensearch-project#65)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added toast notifications for failure cases in rule creation/edit (opensearch-project#70)

* added toast notifications for failure

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated toasts logic

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added experimental indicator; fixed edit detector pages (opensearch-project#71)

* added experimental indicator; fixed edit detector pages

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* fixed links for cancel and save on edit alerts

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated link, breadcrumbs; fixed issues related to api calls

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* edited link to forum

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed a bug impacting redirection to monitor details page after creating a monitor. (opensearch-project#72)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented integration test for create rule workflow. (opensearch-project#75)

* Added some infrastructure to run cypress tests.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented integration test for create rule workflow.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: Amardeepsingh <114732919+amsiglan@users.noreply.github.com>
Co-authored-by: Amardeepsingh <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants