Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 3.0] Add alpha1 qualifier. #1490

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

AWSHurneyt
Copy link
Collaborator

Description

  1. Add alpha1 qualifier.
  2. Fixed imports for 3.0-alpha1.
  3. Removed unused imports.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt AWSHurneyt added release v3.0.0 Issues related to 3.0.0 release labels Feb 27, 2025
@@ -5,7 +5,7 @@
package org.opensearch.securityanalytics.correlation.index.mapper;

import org.apache.lucene.document.FieldType;
import org.apache.lucene.document.KnnVectorField;
import org.apache.lucene.document.KnnFloatVectorField;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, refactored to KnnFloatVectorField based on official documentation recommendation.
https://lucene.apache.org/core/9_12_0/core/org/apache/lucene/document/KnnVectorField.html

@@ -4,7 +4,7 @@
*/
package org.opensearch.securityanalytics.correlation.index.query;

import org.apache.lucene.search.KnnVectorQuery;
import org.apache.lucene.search.KnnFloatVectorQuery;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, refactored to KnnFloatVectorQuery based on official documentation recommendation.
https://lucene.apache.org/core/9_12_0/core/org/apache/lucene/search/KnnVectorQuery.html

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt
Copy link
Collaborator Author

As mentioned in opensearch-project/notifications#1002 (comment), the security test workflow needs to be refactored away from using docker. I'll take that as a follow-up item now that the build assembly is unblocked.

@peterzhuamazon peterzhuamazon merged commit 614184a into opensearch-project:main Feb 27, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release v3.0.0 Issues related to 3.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants