[Release 3.0] Add alpha1 qualifier. #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
commented
Feb 27, 2025
| @@ -5,7 +5,7 @@ | |||
| package org.opensearch.securityanalytics.correlation.index.mapper; | |||
|
|
|||
| import org.apache.lucene.document.FieldType; | |||
| import org.apache.lucene.document.KnnVectorField; | |||
| import org.apache.lucene.document.KnnFloatVectorField; | |||
There was a problem hiding this comment.
For context, refactored to KnnFloatVectorField based on official documentation recommendation.
https://lucene.apache.org/core/9_12_0/core/org/apache/lucene/document/KnnVectorField.html
AWSHurneyt
commented
Feb 27, 2025
| @@ -4,7 +4,7 @@ | |||
| */ | |||
| package org.opensearch.securityanalytics.correlation.index.query; | |||
|
|
|||
| import org.apache.lucene.search.KnnVectorQuery; | |||
| import org.apache.lucene.search.KnnFloatVectorQuery; | |||
There was a problem hiding this comment.
For context, refactored to KnnFloatVectorQuery based on official documentation recommendation.
https://lucene.apache.org/core/9_12_0/core/org/apache/lucene/search/KnnVectorQuery.html
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
requested review from
amsiglan,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
|
As mentioned in opensearch-project/notifications#1002 (comment), the security test workflow needs to be refactored away from using docker. I'll take that as a follow-up item now that the build assembly is unblocked. |
sbcd90
approved these changes
Feb 27, 2025
peterzhuamazon
approved these changes
Feb 27, 2025
66 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.