-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Sigma Rules parser for importing rules based on Sigma schema format-part 1 #6
Conversation
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
=======================================
Coverage ? 65.05%
Complexity ? 99
=======================================
Files ? 26
Lines ? 269
Branches ? 60
=======================================
Hits ? 175
Misses ? 73
Partials ? 21 Continue to review full report at Codecov.
|
*/ | ||
package org.opensearch.securityanalytics.rules.types; | ||
|
||
public class Placeholder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write a TODO comment what this is a placeholder for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lezzago added TODO comment
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, LGTM. Let's open a primary issue for Sigma Parser and add the related/planned part PRs to it for the full context. We can then resolve the issue once all related PRs are out.
yes @getsaurabh02 i created the issue #5 |
address code review comments
* Refactored landing page to direct to the Findings page. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed redundant gitignore entry. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped plugin version from 2.1 to 2.4 to align with backend plugin. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Remove duplicate ioc types
Description
integrate sigma rules-types, exeptions, utils
Design
Issues Resolved
Integrate Sigma Rules parser for importing rules based on Sigma schema format
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.