Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Sigma Rules parser for importing rules based on Sigma schema format-part 1 #6

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Jun 27, 2022

Description

integrate sigma rules-types, exeptions, utils

Design

image (1)

Issues Resolved

Integrate Sigma Rules parser for importing rules based on Sigma schema format

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

sbcd90 added 2 commits June 27, 2022 22:22
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
@sbcd90 sbcd90 requested a review from a team June 27, 2022 23:39
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@05b4b80). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage        ?   65.05%           
  Complexity      ?       99           
=======================================
  Files           ?       26           
  Lines           ?      269           
  Branches        ?       60           
=======================================
  Hits            ?      175           
  Misses          ?       73           
  Partials        ?       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b4b80...66fef3c. Read the comment docs.

@sbcd90 sbcd90 requested review from getsaurabh02 and lezzago June 27, 2022 23:42
*/
package org.opensearch.securityanalytics.rules.types;

public class Placeholder {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a TODO comment what this is a placeholder for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lezzago added TODO comment

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Copy link
Member

@getsaurabh02 getsaurabh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM. Let's open a primary issue for Sigma Parser and add the related/planned part PRs to it for the full context. We can then resolve the issue once all related PRs are out.

@sbcd90
Copy link
Collaborator Author

sbcd90 commented Jun 29, 2022

yes @getsaurabh02 i created the issue #5

@sbcd90 sbcd90 merged commit 806eae0 into opensearch-project:main Jun 29, 2022
sbcd90 pushed a commit to sbcd90/security-analytics that referenced this pull request Jul 8, 2023
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
* Refactored landing page to direct to the Findings page.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Removed redundant gitignore entry.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Bumped plugin version from 2.1 to 2.4 to align with backend plugin.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
jowg-amazon pushed a commit that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants