-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated release notes for 1.2 with copyright updates #856
Updated release notes for 1.2 with copyright updates #856
Conversation
Please add this PR itself to the release notes. |
Signed-off-by: Dave Lago <davelago@amazon.com>
Signed-off-by: Dave Lago <davelago@amazon.com>
30032f5
to
8f19bbd
Compare
Codecov Report
@@ Coverage Diff @@
## main #856 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 87 87
Lines 1906 1906
Branches 247 247
=======================================
Hits 1372 1372
Misses 480 480
Partials 54 54 Continue to review full report at Codecov.
|
@@ -5,7 +5,10 @@ | |||
* Add observability cluster permissions ([#851](https://github.com/opensearch-project/security-dashboards-plugin/pull/851)) | |||
|
|||
### Maintenance | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no empty row after ### Enhancements
, then this empty row is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Signed-off-by: Dave Lago <davelago@amazon.com>
Signed-off-by: Dave Lago davelago@amazon.com
opensearch-project/security-dashboards-plugin pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly
Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Maintenance
Github Issue # or road-map entry, if available:
Added copyright notice updates to release notes for 1.2
Description of changes:
Why these changes are required?
What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)
Is it backport from main branch? (If yes, please add backport PR # and commits #)
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.