Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates guava dependency to latest stable version suggested by whitesource #1594

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Feb 2, 2022

Description

Updates outdated guava dependency. This issue was opened by whitesource as part of version compatibility/vulnerability check. But the version suggested by whitesource was an android toolkit, and hence this PR was opened to update to it to Java toolkit 30.0-jre.

  • Enhancement
  • White-source suggested

Issues Resolved

#1565

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ource

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@DarshitChanpura DarshitChanpura requested a review from a team February 2, 2022 17:43
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #1594 (d99fc43) into main (7592846) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1594      +/-   ##
============================================
+ Coverage     64.57%   64.72%   +0.14%     
- Complexity     3215     3221       +6     
============================================
  Files           247      247              
  Lines         17351    17351              
  Branches       3082     3082              
============================================
+ Hits          11205    11231      +26     
+ Misses         4597     4570      -27     
- Partials       1549     1550       +1     
Impacted Files Coverage Δ
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.25% <0.00%> (+0.76%) ⬆️
...ecurity/configuration/ConfigurationRepository.java 75.27% <0.00%> (+2.19%) ⬆️
.../dlic/auth/http/jwt/keybyoidc/KeySetRetriever.java 79.26% <0.00%> (+2.43%) ⬆️
...ic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java 59.30% <0.00%> (+3.48%) ⬆️
.../auth/http/jwt/keybyoidc/SelfRefreshingKeySet.java 68.30% <0.00%> (+8.45%) ⬆️
...t/keybyoidc/AuthenticatorUnavailableException.java 40.00% <0.00%> (+40.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7592846...d99fc43. Read the comment docs.

@peternied
Copy link
Member

@DarshitChanpura it looks like there are many items on the description from the PR template that haven't been updated, could you please update those so I can approve these changes?

@@ -74,7 +74,7 @@
<bc.version>1.67</bc.version>
<log4j.version>2.17.1</log4j.version>
<slf4j.version>1.7.32</slf4j.version>
<guava.version>25.1-jre</guava.version>
<guava.version>30.0-jre</guava.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lastest version available is 31.0.1-jre

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Feb 8, 2022

@DarshitChanpura it looks like there are many items on the description from the PR template that haven't been updated, could you please update those so I can approve these changes?

I have updated the description to best of my knowledge. If you see anything missing in particular, please let me know so I can fix it right away.

@DarshitChanpura DarshitChanpura merged commit e0be1eb into opensearch-project:main Feb 8, 2022
@peternied
Copy link
Member

Could you remove the 'sign off' on the top of the description?

Is this a backport? If so, please add backport PR # and/or commits #

This change isn't a backport, so I think we can delete this line

Manual testing

This is hard to reproduce without more detail, if we have a set of manual tests cases we follow that you could reference Did the XYZ manual test pass [link] to doc or validation to be conducted by the PR checks

wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
…ource (opensearch-project#1594)

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants