-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates guava dependency to latest stable version suggested by whitesource #1594
Updates guava dependency to latest stable version suggested by whitesource #1594
Conversation
…ource Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1594 +/- ##
============================================
+ Coverage 64.57% 64.72% +0.14%
- Complexity 3215 3221 +6
============================================
Files 247 247
Lines 17351 17351
Branches 3082 3082
============================================
+ Hits 11205 11231 +26
+ Misses 4597 4570 -27
- Partials 1549 1550 +1
Continue to review full report at Codecov.
|
@DarshitChanpura it looks like there are many items on the description from the PR template that haven't been updated, could you please update those so I can approve these changes? |
@@ -74,7 +74,7 @@ | |||
<bc.version>1.67</bc.version> | |||
<log4j.version>2.17.1</log4j.version> | |||
<slf4j.version>1.7.32</slf4j.version> | |||
<guava.version>25.1-jre</guava.version> | |||
<guava.version>30.0-jre</guava.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lastest version available is 31.0.1-jre
I have updated the description to best of my knowledge. If you see anything missing in particular, please let me know so I can fix it right away. |
Could you remove the 'sign off' on the top of the description?
This change isn't a backport, so I think we can delete this line
This is hard to reproduce without more detail, if we have a set of manual tests cases we follow that you could reference |
…ource (opensearch-project#1594) Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Description
Updates outdated guava dependency. This issue was opened by whitesource as part of version compatibility/vulnerability check. But the version suggested by whitesource was an android toolkit, and hence this PR was opened to update to it to Java toolkit
30.0-jre
.Issues Resolved
#1565
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.