Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the plugin-descriptor programmatically #1623

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

peternied
Copy link
Member

Description

After migrating from maven to gradle, the build script for security in OpenSearch-build was broken. We could not use the default script and had to make modifications, see opensearch-project/opensearch-build#1631

Testing

Built locally and confirmed the contents of the programmatically generated file matched the intended behavoir that was previously done by overrides, see https://github.com/opensearch-project/opensearch-build/blob/main/scripts/components/security/build.sh#L70-L71

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied requested a review from a team February 17, 2022 18:06
@peternied peternied self-assigned this Feb 17, 2022
@peternied peternied added the bug Something isn't working label Feb 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #1623 (f23fe3a) into main (5b994af) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f23fe3a differs from pull request most recent head f437b11. Consider uploading reports for the commit f437b11 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1623   +/-   ##
=========================================
  Coverage     64.57%   64.58%           
  Complexity     3215     3215           
=========================================
  Files           247      247           
  Lines         17351    17352    +1     
  Branches       3082     3082           
=========================================
+ Hits          11205    11206    +1     
  Misses         4597     4597           
  Partials       1549     1549           
Impacted Files Coverage Δ
...ecurity/ssl/rest/SecuritySSLReloadCertsAction.java 85.10% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b994af...f437b11. Read the comment docs.

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied merged commit 49e2b75 into opensearch-project:main Feb 17, 2022
@peternied peternied deleted the programmatic-descriptor branch February 17, 2022 19:46
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
* Create the plugin-descriptor programmatically

Signed-off-by: Peter Nied <petern@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants