Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '-SNAPSHOT' from opensearch.version in plugin descriptor #1634

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented Feb 22, 2022

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Maintenance
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[#1633]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

  • Built security plugin 1.3.0.0
  • Installed security plugin 1.3.0.0 on OpenSearch 1.3.0

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cliu123 cliu123 requested a review from a team February 22, 2022 00:53
Signed-off-by: cliu123 <lc12251109@gmail.com>
@cliu123 cliu123 force-pushed the remove_snapshot_from_opensearch.version_in_plugin_descriptor branch from a75b70c to 06c1964 Compare February 22, 2022 00:55
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #1634 (06c1964) into main (4ca99e2) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1634      +/-   ##
============================================
- Coverage     64.59%   64.58%   -0.02%     
  Complexity     3215     3215              
============================================
  Files           247      247              
  Lines         17352    17352              
  Branches       3082     3082              
============================================
- Hits          11209    11206       -3     
- Misses         4593     4597       +4     
+ Partials       1550     1549       -1     
Impacted Files Coverage Δ
...ecurity/configuration/StaticResourceException.java 0.00% <0.00%> (-25.00%) ⬇️
...nsearch/security/dlic/rest/api/AuditApiAction.java 63.82% <0.00%> (-4.26%) ⬇️
...search/security/transport/SecurityInterceptor.java 74.78% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca99e2...06c1964. Read the comment docs.

@peternied
Copy link
Member

@cliu123 I think @dblock has a better proposal for how to address this, could you look at #1627

@cliu123
Copy link
Member Author

cliu123 commented Feb 22, 2022

@cliu123 I think @dblock has a better proposal for how to address this, could you look at #1627

That's a good proposal to generate securityPluginVersion dynamically. Thanks for calling out! We can have a separate PR to adopt that mechanism. But this PR is to remove -SNAPSHOT from the opensearch.version in plugin descriptor in order to fix the incompatility between security plugin and OpenSearch.

@cliu123 cliu123 merged commit 52c7552 into opensearch-project:main Feb 22, 2022
@cliu123 cliu123 deleted the remove_snapshot_from_opensearch.version_in_plugin_descriptor branch February 22, 2022 17:37
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants