Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Git ignore plugin-descriptor.properties file #1651

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented Feb 28, 2022

Signed-off-by: cliu123 lc12251109@gmail.com

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Maintenance
  • Why these changes are required? plugin-descriptor.properties is not needed in version contol.
  • What is the old behavior before changes and new behavior after changes? No behavior changes

Issues Resolved

#1650

Is this a backport? If so, please add backport PR # and/or commits #
Not a backport

Testing

  • Tested on local: plugin-descriptor.properties is not captured by Git.
  • UTs

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: cliu123 <lc12251109@gmail.com>
@cliu123 cliu123 requested a review from a team February 28, 2022 22:52
@codecov-commenter
Copy link

Codecov Report

Merging #1651 (d39dbb5) into main (d3c10b3) will decrease coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1651      +/-   ##
============================================
- Coverage     64.59%   64.05%   -0.54%     
+ Complexity     3214     3187      -27     
============================================
  Files           247      247              
  Lines         17352    17350       -2     
  Branches       3082     3073       -9     
============================================
- Hits          11208    11114      -94     
- Misses         4594     4685      +91     
- Partials       1550     1551       +1     
Impacted Files Coverage Δ
...mazon/dlic/auth/http/jwt/HTTPJwtAuthenticator.java 9.43% <0.00%> (-75.48%) ⬇️
...ava/com/amazon/dlic/auth/ldap2/MakeJava9Happy.java 39.13% <0.00%> (-4.35%) ⬇️
.../org/opensearch/security/support/ConfigHelper.java 80.39% <0.00%> (-1.97%) ⬇️
...com/amazon/dlic/auth/ldap2/PrivilegedProvider.java 49.18% <0.00%> (-1.64%) ⬇️
...security/configuration/DlsFlsFilterLeafReader.java 59.76% <0.00%> (-0.71%) ⬇️
.../org/opensearch/security/auth/BackendRegistry.java 58.85% <0.00%> (-0.53%) ⬇️
...ic/auth/ldap/backend/LDAPAuthorizationBackend.java 57.57% <0.00%> (-0.38%) ⬇️
...zon/dlic/auth/ldap2/LDAPAuthorizationBackend2.java 28.35% <0.00%> (-0.38%) ⬇️
...ecurity/ssl/rest/SecuritySSLReloadCertsAction.java 84.78% <0.00%> (-0.33%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 47.39% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c10b3...d39dbb5. Read the comment docs.

@cliu123 cliu123 merged commit ff40615 into opensearch-project:main Mar 1, 2022
@cliu123 cliu123 deleted the make_git_ignore_plugin-descriptor.properties branch March 1, 2022 17:56
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance] Ignore plugin-descriptor.properties file automatically generated by Gradle build
4 participants