Use proto serialization #2779
Closed
Use proto serialization #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paras Jain <parasjaz@amazon.com>
9 tasks
| * | ||
| * SerializableWrapper here will hold our actual serializable object, and we'll always (de)serialize | ||
| * SerializableWrapper object. Protostuff will internally construct and maintain schemas for underlying | ||
| * classes. |
| @@ -126,6 +128,8 @@ public <T extends TransportResponse> void sendRequestDecorate(AsyncSender sender | |||
| final String origCCSTransientFls = getThreadContext().getTransient(ConfigConstants.OPENDISTRO_SECURITY_FLS_FIELDS_CCS); | |||
| final String origCCSTransientMf = getThreadContext().getTransient(ConfigConstants.OPENDISTRO_SECURITY_MASKED_FIELD_CCS); | |||
|
|
|||
| final boolean useJDKSerialization = connection.getVersion().before(Version.V_2_7_0); | |||
| @@ -296,6 +303,10 @@ else if(!Strings.isNullOrEmpty(injectedUserHeader)) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private void serializeHeadersUsingProtoForVersionUpgrade() { | |||
There was a problem hiding this comment.
We can move this function to HeaderHelpers to re-use
|
Looks like this pull request has stalled for a little bit @parasjain1 thoughts on picking this back up? For the content of the pull request itself, you say this is faster, how are you quantifying this? |
|
Closing this in favour of - #2802 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Resolves #2780
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.