Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor InternalAuditLogTest to use Awaitility #5214

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Mar 25, 2025

Description

Refactor InternalAuditLogTest to use Awaitility

This test had flakiness that was fixed in #5071. I'm creating this small PR to refactor this to use Awaitility instead which is a good utility to wait for a particular result in a test.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Test fix

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.75%. Comparing base (bfc0f4a) to head (9c7ef12).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5214      +/-   ##
==========================================
+ Coverage   71.71%   71.75%   +0.03%     
==========================================
  Files         337      337              
  Lines       22789    22789              
  Branches     3606     3606              
==========================================
+ Hits        16344    16352       +8     
+ Misses       4649     4637      -12     
- Partials     1796     1800       +4     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cwperks cwperks merged commit da21abf into opensearch-project:main Mar 27, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants