improve sriov operator must-gather information #480
Conversation
collection-scripts/gather_sriov
Outdated
| @@ -110,9 +112,16 @@ for CONFIG_DAEMON_POD in ${CONFIG_DAEMON_PODS[@]}; do | |||
| out=$(oc exec -n ${operator_ns} "${CONFIG_DAEMON_POD}" -c sriov-network-config-daemon -- chroot /host \ | |||
| /bin/bash -c "cat var/log/multus.log" 2>/dev/null) && echo "$out" 1> "${MULTUS_LOG_PATH}" & PIDS+=($!) | |||
|
|
|||
| # collect kernel lockdown mode | |||
| oc exec -n ${operator_ns} "${CONFIG_DAEMON_POD}" -c sriov-network-config-daemon -- chroot /host \ | |||
| /bin/bash -c "/sys/kernel/security/lockdown" > "${KERNEL_LOCKDOWN_FILE_PATH}" & PIDS+=($!) | |||
There was a problem hiding this comment.
| /bin/bash -c "/sys/kernel/security/lockdown" > "${KERNEL_LOCKDOWN_FILE_PATH}" & PIDS+=($!) | |
| /bin/bash -c "cat /sys/kernel/security/lockdown" > "${KERNEL_LOCKDOWN_FILE_PATH}" & PIDS+=($!) |
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
SchSeba
force-pushed
the
improve_sriov_operator_gather
branch
from
a4780d7 to
353155a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SchSeba, zeeke The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@SchSeba: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
In general (and this isn't caused by this PR; per-say) I see 2 issues with this collection script.
In both situations the time to collect and the size of the data returned are potential issues or problems to consider. Code paths like this one in this collection script make meeting these SLO's potentially difficult; given that the aren't optimized collection operations and/or unbounded (not targeted as specific nodes/instances). |
No description provided.